Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor #3406

Closed
wants to merge 5 commits into from
+3 −3
Closed

8080185: [TESTBUG] Test instructions need to be updated for test java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor #3406

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1c023ab
8080185: [TESTBUG] Test instructions need to be updated for test java…
prsadhuk Apr 9, 2021
2976e13
Fix
prsadhuk Apr 9, 2021
6e7f6ee
Remove Outlook requirement
prsadhuk Apr 10, 2021
1970ba9
Reinstate Outlook requirement
prsadhuk Apr 14, 2021
992bb12
Fix
prsadhuk Apr 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 test/jdk/ProblemList.txt
View file
Open in desktop
@@ -850,7 +850,6 @@ java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 generic-all
javax/swing/JFileChooser/6698013/bug6698013.java 8024419 macosx-all
javax/swing/JColorChooser/8065098/bug8065098.java 8065647 macosx-all
java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 generic-all
java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html 8080185 macosx-all,linux-all
prsadhuk marked this conversation as resolved.
Show resolved Hide resolved
javax/swing/JTabbedPane/4666224/bug4666224.html 8144124 macosx-all
java/awt/event/MouseEvent/AltGraphModifierTest/AltGraphModifierTest.java 8162380 generic-all
java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java 8163086 macosx-all
3 test/jdk/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html
View file
Open in desktop
@@ -1,5 +1,5 @@
<!--
Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2009, 2021, Oracle and/or its affiliates. All rights reserved.
DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
This code is free software; you can redistribute it and/or modify it
@@ -26,6 +26,7 @@
@test
@bug 6242241
@summary Tests basic DnD functionality in an applet
@requires (os.family == "windows")
@author Your Name: Alexey Utkin area=dnd
@run applet/manual=yesno DnDFileGroupDescriptor.html
-->
6 test/jdk/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java
View file
Open in desktop
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2009, 2021, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@@ -39,9 +39,7 @@ public void init() {

String[] instructions = {
"The applet window contains a red field.",
"1. Start MS Outlook program. Find and open ",
" the mail form with attachments.",
"2. Select attachments from the mail and drag into a red field of applet.",
"1. Select any file from File Explorer and drag into a red field of applet.",
Copy link
Member

@mrserb mrserb Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check that "any file from File Explorer" can reproduce the initial JDK-6242241 bug?

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will work fine as initial JDK-6242241 bug says "It works fine when dragging from Windows Explorer" but you told to remove Outlook requirement. The JDK-6242241 bug is specifically Outlook issue so that's why I told "regression test was added specially for Microsoft Outlook drag issues"

Copy link
Member

@mrserb mrserb Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug was filed to remove the "Outlook requirement" but it does not mean that we should lose the opportunity to verify the JDK-6242241.

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I am understanding..
JDK-6242241 was Outlook bug so I am not sure how to remove "Outlook requirement" to verify that fix and thus bug? I don't think we can satisfy both requirement!!!
Are you saying we will add @requires but not remove from problem list?
Or add
Outlook steps plus
"If Outlook is not present in some platform then you can test with any file from File Explorer"

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think the bug was raised by internal SQE when it was thought that the test could be run on multiple platforms but
http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/d8efcad28072
made sure it can be run only for windows (although fix not done fully). So, I think we should just add @requires in the html file and not put much stress on removing Outlook requirement.

Copy link
Contributor Author

@prsadhuk prsadhuk Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more comments on this? I tried removing "Outlook requirement" but couldn't so reinstated back based on the above comments.

Copy link
Member

@mrserb mrserb Apr 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be good to try some possibilities to remove the "Outlook requirement" and at the same time cover the verification of the JDK-6242241. So yes we need to have both. We probably can create the native app from which the user should be able to drag the data, or we may try to run two java processes, etc to emulate the DnD from the Outlook.

" When the mouse enters the field during the drag, the application ",
" should change the cursor form to OLE-copy and field color to yellow.",
"3. Release the mouse button (drop attachments) over the field.",