Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256465: [macos] Java frame and dialog presented full screen freeze application #3407

Closed
wants to merge 13 commits into from
@@ -46,7 +46,6 @@
import java.beans.PropertyChangeListener;
import java.lang.reflect.InvocationTargetException;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Comparator;
@@ -69,6 +68,7 @@
import sun.lwawt.LWWindowPeer;
import sun.lwawt.LWWindowPeer.PeerType;
import sun.lwawt.PlatformWindow;
import sun.security.action.GetPropertyAction;
import sun.util.logging.PlatformLogger;

public class CPlatformWindow extends CFRetainedResource implements PlatformWindow {
@@ -128,8 +128,8 @@ private static native void nativeSetNSWindowStandardFrame(long nsWindowPtr,
public static final String WINDOW_TITLE_VISIBLE = "apple.awt.windowTitleVisible";

// This system property is used in javafx as well
trebari marked this conversation as resolved.
Show resolved Hide resolved
public static final String MAC_OS_TABBED_WINDOW = System.getProperty("jdk.allowMacOSTabbedWindows");
public static boolean allowMacOSAutomaticWindowTabbing;
public static final String MAC_OS_TABBED_WINDOW = AccessController.doPrivileged(
kevinrushforth marked this conversation as resolved.
Show resolved Hide resolved
new GetPropertyAction("jdk.allowMacOSTabbedWindows"));

// Yeah, I know. But it's easier to deal with ints from JNI
static final int MODELESS = 0;
@@ -195,13 +195,7 @@ static boolean IS(final int bits, final int mask) {
}

static {
AccessController.doPrivileged(
(PrivilegedAction<Object>) () -> {
allowMacOSAutomaticWindowTabbing = Boolean.parseBoolean(
MAC_OS_TABBED_WINDOW);
return null;
});
nativeSetAllowAutomaticTabbingProperty(allowMacOSAutomaticWindowTabbing);
nativeSetAllowAutomaticTabbingProperty(Boolean.parseBoolean(MAC_OS_TABBED_WINDOW));
}

@SuppressWarnings({"unchecked", "rawtypes"})