Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265018: [AIX] FileDispatcherImpl.c:31:10: fatal error: 'sys/mount.h' file not found #3424

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Apr 9, 2021

#3366 introduced new includes which are not available on AIX, but they are only used on MacOS.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265018: [AIX] FileDispatcherImpl.c:31:10: fatal error: 'sys/mount.h' file not found

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3424/head:pull/3424
$ git checkout pull/3424

Update a local copy of the PR:
$ git checkout pull/3424
$ git pull https://git.openjdk.java.net/jdk pull/3424/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3424

View PR using the GUI difftool:
$ git pr show -t 3424

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3424.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 9, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio label Apr 9, 2021
@TheRealMDoerr TheRealMDoerr marked this pull request as ready for review Apr 9, 2021
@openjdk openjdk bot added the rfr label Apr 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 9, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 9, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265018: [AIX] FileDispatcherImpl.c:31:10: fatal error: 'sys/mount.h' file not found

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 76bd313: 8264872: Dependencies: Migrate to PerfData counters
  • 07c8ff4: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp
  • 863feab: 8005295: Use mandated information for printing of repeating annotations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 9, 2021
#include <sys/mount.h>
#include <sys/param.h>
#endif
Copy link
Contributor

@AlanBateman AlanBateman Apr 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS specific includes are #ifdef _ALLBSD_SOURCE in this file so we can move them there (sorry, there is inconsistency in this source files as to whether _ALLBSD_SOURCE or MACOSX is used, we need to clean this up sometimes).

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Apr 12, 2021

Thanks for the review and the comment.
Right, I think the related code should be BSD specific, not MacOS specific. So a larger cleanup change will be appreciated.
This PR is just to fix the AIX build.
/integrate

@openjdk openjdk bot closed this Apr 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@TheRealMDoerr Since your change was applied there have been 10 commits pushed to the master branch:

  • ecef1fc: 8264972: Unused TypeFunc declared in OptoRuntime
  • 440c34a: 8264644: Add PrintClassLoaderDataGraphAtExit to print the detailed CLD graph
  • b1ebf82: 8264358: Don't create invalid oop in method handle tracing
  • 627ad9f: 8262328: Templatize JVMFlag boilerplate access methods
  • c15680e: 8264868: Reduce inclusion of registerMap.hpp and register.hpp
  • 5784f6b: 8264948: Check for TLS extensions total length
  • 42f4d70: 8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB
  • 76bd313: 8264872: Dependencies: Migrate to PerfData counters
  • 07c8ff4: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp
  • 863feab: 8005295: Use mandated information for printing of repeating annotations

Your commit was automatically rebased without conflicts.

Pushed as commit cb2806d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8265018_AIX_build branch Apr 12, 2021
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Apr 12, 2021

Thanks for the review and the comment.
Right, I think the related code should be BSD specific, not MacOS specific. So a larger cleanup change will be appreciated.
This PR is just to fix the AIX build.

Sure but for this PR then please don't put #ifdef MACOSX in the middle of the shared includes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated nio
3 participants