Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264972: Unused TypeFunc declared in OptoRuntime #3429

Closed
wants to merge 1 commit into from

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Apr 12, 2021

When investigating some C2 related stuff, I noticed that some TypeFunc are declared in OptoRuntime since JDK6:

// leaf on stack replacement interpreter accessor types
static const TypeFunc* fetch_int_Type();
static const TypeFunc* fetch_long_Type();
static const TypeFunc* fetch_float_Type();
static const TypeFunc* fetch_double_Type();
static const TypeFunc* fetch_oop_Type();
static const TypeFunc* fetch_monitor_Type();

They are neither used nor implemented. It looks like we can remove them(I'm curious about their stories/history.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3429/head:pull/3429
$ git checkout pull/3429

Update a local copy of the PR:
$ git checkout pull/3429
$ git pull https://git.openjdk.java.net/jdk pull/3429/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3429

View PR using the GUI difftool:
$ git pr show -t 3429

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3429.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 12, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@kelthuzadx The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 12, 2021

Webrevs

Loading

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Good catch. Looks good and trivial to me.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 12, 2021

Thank you Tobias. It's trivial indeed.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264972: Unused TypeFunc declared in OptoRuntime

Reviewed-by: thartmann, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • 440c34a: 8264644: Add PrintClassLoaderDataGraphAtExit to print the detailed CLD graph
  • b1ebf82: 8264358: Don't create invalid oop in method handle tracing
  • 627ad9f: 8262328: Templatize JVMFlag boilerplate access methods
  • c15680e: 8264868: Reduce inclusion of registerMap.hpp and register.hpp
  • 5784f6b: 8264948: Check for TLS extensions total length
  • 42f4d70: 8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB
  • 76bd313: 8264872: Dependencies: Migrate to PerfData counters
  • 07c8ff4: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp
  • 863feab: 8005295: Use mandated information for printing of repeating annotations
  • f26cd2a: 8264997: Remove SystemDictionary::cache_get
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/a45733f8400509f9e8438ff3e7873f1939f7abb2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Apr 12, 2021
@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 12, 2021

/integrate

Loading

@openjdk openjdk bot added the sponsor label Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@kelthuzadx
Your change (at version 8f3e8a4) is now ready to be sponsored by a Committer.

Loading

Copy link
Contributor

@shipilev shipilev left a comment

This apparently predates OpenJDK history. Looks fine.

Loading

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 12, 2021

/sponsor

Loading

@openjdk openjdk bot closed this Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@shipilev @kelthuzadx Since your change was applied there have been 20 commits pushed to the master branch:

  • 440c34a: 8264644: Add PrintClassLoaderDataGraphAtExit to print the detailed CLD graph
  • b1ebf82: 8264358: Don't create invalid oop in method handle tracing
  • 627ad9f: 8262328: Templatize JVMFlag boilerplate access methods
  • c15680e: 8264868: Reduce inclusion of registerMap.hpp and register.hpp
  • 5784f6b: 8264948: Check for TLS extensions total length
  • 42f4d70: 8264649: runtime/InternalApi/ThreadCpuTimesDeadlock.java crash in fastdebug C2 with -XX:-UseTLAB
  • 76bd313: 8264872: Dependencies: Migrate to PerfData counters
  • 07c8ff4: 8264871: Dependencies: Miscellaneous cleanups in dependencies.cpp
  • 863feab: 8005295: Use mandated information for printing of repeating annotations
  • f26cd2a: 8264997: Remove SystemDictionary::cache_get
  • ... and 10 more: https://git.openjdk.java.net/jdk/compare/a45733f8400509f9e8438ff3e7873f1939f7abb2...master

Your commit was automatically rebased without conflicts.

Pushed as commit ecef1fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@openjdk openjdk bot removed the rfr label Apr 12, 2021
@kelthuzadx kelthuzadx deleted the remove_typefunc branch Apr 12, 2021
@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 12, 2021

This apparently predates OpenJDK history. Looks fine.

Yes, it seems an ancient code. I googled it but got nothing except source codes in OpenJDK.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants