-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8233567: [TESTBUG] FocusSubRequestTest.java fails on macos #3430
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@prsadhuk Since your change was applied there have been 10 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit b90ad76. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This test was problemlisted during nightly testing of jdk on macos which seems to be caused by the fact that proper waiting was not done to make sure frame is visible before commencing the test, which can be problematic in some of the slower CI macos system.
Modified the wait-till-frame-is-visible code to make it more in sync with what other similar test use.
Several iterations of the test works fine in all platforms after this modification.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3430/head:pull/3430
$ git checkout pull/3430
Update a local copy of the PR:
$ git checkout pull/3430
$ git pull https://git.openjdk.java.net/jdk pull/3430/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3430
View PR using the GUI difftool:
$ git pr show -t 3430
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3430.diff