-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M #3432
Conversation
👋 Welcome back hshi! A progress list of the required criteria for merging this PR into |
@huishi-hs The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Hui, looks good - thank you for testing and making this a bit more robust.
@huishi-hs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 229 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mgronlun) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
I did see this test fail when running on linux-aarch64: [2021-04-16T12:55:44,162Z] java.lang.RuntimeException: 'Decrease globalbuffersize or increase memorysize or adjust global/threadbuffersize' missing from stdout/stderr |
@mgronlun Thanks for your reivew and test! Is default page size larger than 4k in your aarch64 enivronment? I found an aarch64 mchine default page size 64k. Testing on both linux aarch64/x64 pass now. ./build/linux-aarch64-server-release/jdk/bin/java -XX:StartFlightRecording -XX:FlightRecorderOptions:memorysize=1m,numglobalbuffers=256 -Xlog:arguments=trace -version |
@mgronlun Could you please help review again for updated commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are green after the update - thank you.
Thanks for your review! |
/integrate |
@huishi-hs |
Could someone give a second review before integrate this? |
/sponsor |
@mgronlun @huishi-hs Since your change was applied there have been 277 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 377b346. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
…ize=30M
Fix misc explicit JFR memory option caused crash and assertion (https://bugs.openjdk.java.net/browse/JDK-8241773).
Fix SIGFPE crash in div_total_by_per_unit.
a) In valid_memory_relations, check threadbuffersize should not larger than memorysize.
b) In "void thread_buffer_size(JfrMemoryOptions* options)", calculate memorysize if it isn't configured, avoid SIGFPE when thread buffer size is larger than default memorysize.
Fix "assert(free_size() == size, "invariant");" in JfrBuffer::initialize.
Limit globalbuffersize and threadbuffersize under 2G, avoid size_t to u4 coversion lost.
Check and report possible inconsistent conditions after jfr memory size adjustment.
a) globalbuffercount < MIN_BUFFER_COUNT
b) globalbuffersize < threadbuffersize
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3432/head:pull/3432
$ git checkout pull/3432
Update a local copy of the PR:
$ git checkout pull/3432
$ git pull https://git.openjdk.java.net/jdk pull/3432/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3432
View PR using the GUI difftool:
$ git pr show -t 3432
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3432.diff