Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265082: test/hotspot/jtreg/gc/g1/TestG1SkipCompaction.java fails validate-source #3438

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 12, 2021

A trivial fix to fix the "validate-source" failure in Tier1 due to the bad copyright
header in test/hotspot/jtreg/gc/g1/TestG1SkipCompaction.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265082: test/hotspot/jtreg/gc/g1/TestG1SkipCompaction.java fails validate-source

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3438/head:pull/3438
$ git checkout pull/3438

Update a local copy of the PR:
$ git checkout pull/3438
$ git pull https://git.openjdk.java.net/jdk pull/3438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3438

View PR using the GUI difftool:
$ git pr show -t 3438

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3438.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-gc
/label add hotspot-runtime

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review April 12, 2021 16:03
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 12, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 12, 2021
@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 12, 2021
@openjdk
Copy link

openjdk bot commented Apr 12, 2021

@dcubed-ojdk
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Apr 12, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265082: test/hotspot/jtreg/gc/g1/TestG1SkipCompaction.java fails validate-source

Reviewed-by: mikael, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 27f4b27: 8264623: Change to Xcode 12.4 for building on Macos at Oracle

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated hotspot-runtime hotspot-runtime-dev@openjdk.org labels Apr 12, 2021
@openjdk
Copy link

openjdk bot commented Apr 12, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 12, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@vidmik - Thanks for the fast review!

/integrate

@openjdk openjdk bot closed this Apr 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 12, 2021
@openjdk
Copy link

openjdk bot commented Apr 12, 2021

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • 27f4b27: 8264623: Change to Xcode 12.4 for building on Macos at Oracle

Your commit was automatically rebased without conflicts.

Pushed as commit f479437.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk
Copy link
Member Author

@erikj79 - Thanks for your review also.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8265082 branch April 12, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants