Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265084: [BACKOUT] 8264954: unified handling for VectorMask object re-materialization during de-optimization #3440

Closed
wants to merge 1 commit into from

Conversation

@vnkozlov
Copy link
Contributor

@vnkozlov vnkozlov commented Apr 12, 2021

JDK-8264954 changes caused failures on Aarch64 in Tier3 testing and needs to be backed out.

Tested tier1 and ran jdk/incubator/vector/ tests on linux-x64 and linux-aarch64 machines.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265084: [BACKOUT] 8264954: unified handling for VectorMask object re-materialization during de-optimization

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3440/head:pull/3440
$ git checkout pull/3440

Update a local copy of the PR:
$ git checkout pull/3440
$ git pull https://git.openjdk.java.net/jdk pull/3440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3440

View PR using the GUI difftool:
$ git pr show -t 3440

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3440.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 12, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Apr 12, 2021

/label add hotspot-compiler

Loading

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

This appears to be an accurate [BACKOUT] of the original patch.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265084: [BACKOUT] 8264954: unified handling for VectorMask object re-materialization during de-optimization

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 9dd9625: 8263763: Synthetic constructor parameters of enum are not considered for annotation indices
  • 1ee80e0: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding
  • d84a7e5: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@vnkozlov
The hotspot-compiler label was successfully added.

Loading

@vnkozlov
Copy link
Contributor Author

@vnkozlov vnkozlov commented Apr 12, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 12, 2021

@vnkozlov Since your change was applied there have been 3 commits pushed to the master branch:

  • 9dd9625: 8263763: Synthetic constructor parameters of enum are not considered for annotation indices
  • 1ee80e0: 8261355: No data buffering in SunPKCS11 Cipher encryption when the underlying mechanism has no padding
  • d84a7e5: 8264124: Update MXBean specification and implementation to extend mapping of CompositeType to records

Your commit was automatically rebased without conflicts.

Pushed as commit 18bec9c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@vnkozlov vnkozlov deleted the JDK-8265084 branch Apr 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 12, 2021

Webrevs

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants