-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked. #3441
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
Please confirm that none of them are in the problem list. |
Webrevs
|
I do confirm that. |
@@ -1,234 +0,0 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "TestApplet.java" near this file is part of the test and can be removed as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 22 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
@azvegint Since your change was applied there have been 23 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 26186ec. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This fix simply removes tests mentioned in the bug with for unsupported scenarios(applets in browser).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3441/head:pull/3441
$ git checkout pull/3441
Update a local copy of the PR:
$ git checkout pull/3441
$ git pull https://git.openjdk.java.net/jdk pull/3441/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3441
View PR using the GUI difftool:
$ git pr show -t 3441
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3441.diff