8265047: Inconsistent warning message in jcmd VM.log #3448

jyukutyo · 2021-04-13T04:23:52Z

When reconfiguring log output options of an existing log setting with jcmd VM.log and the file name, a warning message is shown. However, when reconfiguring them with jcmd VM.log and the output index, the message is not shown.

$ java -Xlog::sample.log:: Sample
$ jcmd 4976 VM.log list
Log output configuration:
 #0: stdout all=warning uptime,level,tags
 #1: stderr all=off uptime,level,tags
 #2: file=sample.log all=info uptime,level,tags filecount=5,filesize=20480K

$ jcmd 4976 VM.log output="sample.log" output_options="filecount=100"
4976:
Output options for existing outputs are ignored.

$ jcmd 4976 VM.log output="#2" output_options="filecount=100"
4976:
Command executed successfully

It's better to show the same message also in the latter case, I think. Because the output options is not updated in both cases.

$ jcmd 4976 VM.log list
 #0: stdout all=warning uptime,level,tags
 #1: stderr all=off uptime,level,tags
 #2: file=sample.log all=info uptime,level,tags filecount=5,filesize=20480K (reconfigured)

This pull request enable to show the warning message when specifying the output index.

$ java -Xlog::sample.log:: Sample
$ jcmd 5054 VM.log output="sample.log" output_options="filecount=100"
5054:
Output options for existing outputs are ignored.

$ jcmd 5054 VM.log output="#2" output_options="filecount=100"
5054:
Output options for existing outputs are ignored.

gtest result

$ ./build/linux-x86_64-server-fastdebug/hotspot/variant-server/libjvm/gtest/gtestLauncher -jdk:./build/linux-x86_64-server-fastdebug/jdk --gtest_filter=LogConfigurationTest.\*
Note: Google Test filter = LogConfigurationTest.*
[==========] Running 15 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 15 tests from LogConfigurationTest
[ RUN      ] LogConfigurationTest.describe_vm
[       OK ] LogConfigurationTest.describe_vm (1 ms)
[ RUN      ] LogConfigurationTest.update_output_vm
[       OK ] LogConfigurationTest.update_output_vm (0 ms)
[ RUN      ] LogConfigurationTest.add_new_output_vm
[       OK ] LogConfigurationTest.add_new_output_vm (0 ms)
[ RUN      ] LogConfigurationTest.disable_logging_vm
[       OK ] LogConfigurationTest.disable_logging_vm (1 ms)
[ RUN      ] LogConfigurationTest.disable_output_vm
[       OK ] LogConfigurationTest.disable_output_vm (0 ms)
[ RUN      ] LogConfigurationTest.reconfigure_decorators_vm
[       OK ] LogConfigurationTest.reconfigure_decorators_vm (0 ms)
[ RUN      ] LogConfigurationTest.invalid_configure_options_vm
[       OK ] LogConfigurationTest.invalid_configure_options_vm (0 ms)
[ RUN      ] LogConfigurationTest.parse_empty_command_line_arguments_vm
[0.462s][warning][logging] Ignoring excess -Xlog options: ""
[       OK ] LogConfigurationTest.parse_empty_command_line_arguments_vm (0 ms)
[ RUN      ] LogConfigurationTest.parse_command_line_arguments_vm
[       OK ] LogConfigurationTest.parse_command_line_arguments_vm (1 ms)
[ RUN      ] LogConfigurationTest.parse_log_arguments_vm
[       OK ] LogConfigurationTest.parse_log_arguments_vm (188 ms)
[ RUN      ] LogConfigurationTest.configure_stdout_vm
[       OK ] LogConfigurationTest.configure_stdout_vm (2 ms)
[ RUN      ] LogConfigurationTest.subscribe_vm
[       OK ] LogConfigurationTest.subscribe_vm (2 ms)
[ RUN      ] LogConfigurationTest.parse_invalid_tagset_vm
[       OK ] LogConfigurationTest.parse_invalid_tagset_vm (0 ms)
[ RUN      ] LogConfigurationTest.output_name_normalization_vm
[       OK ] LogConfigurationTest.output_name_normalization_vm (1 ms)
[ RUN      ] LogConfigurationTest.suggest_similar_selection_vm
[       OK ] LogConfigurationTest.suggest_similar_selection_vm (1 ms)
[----------] 15 tests from LogConfigurationTest (658 ms total)

[----------] Global test environment tear-down
[==========] 15 tests from 1 test case ran. (659 ms total)
[  PASSED  ] 15 tests.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265047: Inconsistent warning message in jcmd VM.log

Reviewers

David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to e37e8c5
Thomas Stuefe (@tstuefe - Reviewer) ⚠️ Review applies to e37e8c5
Serguei Spitsyn (@sspitsyn - Reviewer) ⚠️ Review applies to e37e8c5

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3448/head:pull/3448
$ git checkout pull/3448

Update a local copy of the PR:
$ git checkout pull/3448
$ git pull https://git.openjdk.java.net/jdk pull/3448/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3448

View PR using the GUI difftool:
$ git pr show -t 3448

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3448.diff

bridgekeeper · 2021-04-13T04:24:16Z

👋 Welcome back ksakata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-04-13T04:25:57Z

@jyukutyo The following label will be automatically applied to this pull request:

hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-04-13T07:33:04Z

Webrevs

01: Full - Incremental (d7b0627f)
00: Full (e37e8c50)

plummercj · 2021-04-20T17:36:27Z

/label serviceability

openjdk · 2021-04-20T17:36:46Z

@plummercj
The serviceability label was successfully added.

dholmes-ora

Sorry for the delay in noticing this PR!

Fix looks good. One nit on variable naming below.

Thanks,
David

dholmes-ora · 2021-05-04T23:50:16Z

src/hotspot/share/logging/logConfiguration.cpp

@@ -427,6 +427,7 @@ bool LogConfiguration::parse_log_arguments(const char* outputstr,

  ConfigurationLock cl;
  size_t idx;
+  bool is_added = false;


Nit: was_added (or even just added)

Thank you, David. I changed is_added to added.

openjdk · 2021-05-04T23:54:29Z

@jyukutyo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265047: Inconsistent warning message in jcmd VM.log

Reviewed-by: dholmes, stuefe, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 436 new commits pushed to the master branch:

20ad428: 8180568: Refactor javax/crypto shell tests to plain java tests
138d573: 8262392: Update Mesa 3-D Headers to version 21.0.3
9de62a4: 8266505: Cleanup LibraryCallKit::make_unsafe_address()
1885c83: 8266504: Remove leftovers from BarrierSetAssemblerC1
6018336: 8259316: [REDO] C1/C2 compiler support for blackholes
f07bb2f: 8250766: javadoc adds redundant spaces when @see program element is wrapped
61bb6ec: 8266453: Shenandoah: Disable write protections before patching nmethod in nmethod_barrier on MacOSX/AArch64
a05e8e2: 8266497: Remove unnecessary EMCP liveness indication
6ba911d: 8266498: Make debug ps() call print_stack
ef0f693: 8266499: Delete dead code in aarch64.ad
... and 426 more: https://git.openjdk.java.net/jdk/compare/b1ebf82269fa85bed859ffafacd59ed000f22bd0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @tstuefe, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

navyxliu · 2021-05-05T06:54:45Z

Your bugfix looks good to me.
I am not a reviewer. I just happen to work on this file recently. You still need reviewer's approval.

tstuefe

Looks good.

sspitsyn

Looks good to me.
Thanks,
Serguei

jyukutyo

Thank you for your reviews!

jyukutyo · 2021-05-06T06:18:38Z

src/hotspot/share/logging/logConfiguration.cpp

@@ -427,6 +427,7 @@ bool LogConfiguration::parse_log_arguments(const char* outputstr,

  ConfigurationLock cl;
  size_t idx;
+  bool is_added = false;


Thank you, David. I changed is_added to added.

jyukutyo · 2021-05-06T06:53:58Z

/integrate

openjdk · 2021-05-06T06:55:18Z

@jyukutyo
Your change (at version d7b0627) is now ready to be sponsored by a Committer.

tstuefe · 2021-05-06T12:06:30Z

/sponsor

openjdk · 2021-05-06T12:07:49Z

@tstuefe @jyukutyo Since your change was applied there have been 442 commits pushed to the master branch:

ea30bd6: 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify
0f9852c: 8266168: -Wmaybe-uninitialized happens in check_code.c
a86ee9b: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8
2dd5667: 8266018: Shenandoah: fix an incorrect assert
22ca62c: 8266542: Remove broken -XX:-UseLoopSafepoints flag
7835cdb: 8265915: adjust state_unloading_cycle compuation order in nmethod::is_unloading
20ad428: 8180568: Refactor javax/crypto shell tests to plain java tests
138d573: 8262392: Update Mesa 3-D Headers to version 21.0.3
9de62a4: 8266505: Cleanup LibraryCallKit::make_unsafe_address()
1885c83: 8266504: Remove leftovers from BarrierSetAssemblerC1
... and 432 more: https://git.openjdk.java.net/jdk/compare/b1ebf82269fa85bed859ffafacd59ed000f22bd0...master

Your commit was automatically rebased without conflicts.

Pushed as commit 51f5adf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Show a warning whenever trying to update output options

2a224ff

openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 13, 2021

Update copyright

e37e8c5

jyukutyo marked this pull request as ready for review April 13, 2021 07:28

openjdk bot added the rfr Pull request is ready for review label Apr 13, 2021

openjdk bot added the serviceability serviceability-dev@openjdk.org label Apr 20, 2021

dholmes-ora approved these changes May 4, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label May 4, 2021

tstuefe approved these changes May 5, 2021

View reviewed changes

sspitsyn approved these changes May 5, 2021

View reviewed changes

Change variable name to better one

d7b0627

jyukutyo commented May 6, 2021

View reviewed changes

openjdk bot added the sponsor Pull request is ready to be sponsored label May 6, 2021

openjdk bot closed this May 6, 2021

openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2021

jyukutyo deleted the JDK-8265047_message_in_jcmd_vmlog branch June 15, 2022 09:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8265047: Inconsistent warning message in jcmd VM.log #3448

8265047: Inconsistent warning message in jcmd VM.log #3448

jyukutyo commented Apr 13, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

mlbridge bot commented Apr 13, 2021 •

edited

Loading

plummercj commented Apr 20, 2021

openjdk bot commented Apr 20, 2021

dholmes-ora left a comment

dholmes-ora May 4, 2021

jyukutyo May 6, 2021

openjdk bot commented May 4, 2021 •

edited

Loading

navyxliu commented May 5, 2021

tstuefe left a comment

sspitsyn left a comment

jyukutyo left a comment

jyukutyo May 6, 2021

jyukutyo commented May 6, 2021

openjdk bot commented May 6, 2021

tstuefe commented May 6, 2021

openjdk bot commented May 6, 2021

8265047: Inconsistent warning message in jcmd VM.log #3448

8265047: Inconsistent warning message in jcmd VM.log #3448

Conversation

jyukutyo commented Apr 13, 2021 • edited by openjdk bot Loading

gtest result

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

mlbridge bot commented Apr 13, 2021 • edited Loading

Webrevs

plummercj commented Apr 20, 2021

openjdk bot commented Apr 20, 2021

dholmes-ora left a comment

Choose a reason for hiding this comment

dholmes-ora May 4, 2021

Choose a reason for hiding this comment

jyukutyo May 6, 2021

Choose a reason for hiding this comment

openjdk bot commented May 4, 2021 • edited Loading

navyxliu commented May 5, 2021

tstuefe left a comment

Choose a reason for hiding this comment

sspitsyn left a comment

Choose a reason for hiding this comment

jyukutyo left a comment

Choose a reason for hiding this comment

jyukutyo May 6, 2021

Choose a reason for hiding this comment

jyukutyo commented May 6, 2021

openjdk bot commented May 6, 2021

tstuefe commented May 6, 2021

openjdk bot commented May 6, 2021

jyukutyo commented Apr 13, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 13, 2021 •

edited

Loading

openjdk bot commented May 4, 2021 •

edited

Loading