Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233564: [TESTBUG] MouseComboBoxTest.java is failing #3456

Closed
wants to merge 5 commits into from

Conversation

@prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 13, 2021

Test was problemlisted due to it failing repeatedly on macos in automated nightly testing citing "java.awt.IllegalComponentStateException: component must be showing on the screen to determine its location "
Added delay after the setVisible() is called to make sure enough time is given for frame to be visible, which is in sync with what we do for similar other tests.
Also, made the frame to center of screen and increase the autoDelay time to 100ms which is also same as done in similar to other tests.
Several iterations of the test works fine in all platforms after this modification.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233564: [TESTBUG] MouseComboBoxTest.java is failing

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3456/head:pull/3456
$ git checkout pull/3456

Update a local copy of the PR:
$ git checkout pull/3456
$ git pull https://git.openjdk.java.net/jdk pull/3456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3456

View PR using the GUI difftool:
$ git pr show -t 3456

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3456.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 13, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 13, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 13, 2021

Webrevs

Copy link
Member

@jayathirthrao jayathirthrao left a comment

I am not 100% sure about adding additional 1000ms delay after creating GUI. Since it is mentioned as common approach(may be because of slow CI systems), change looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233564: [TESTBUG] MouseComboBoxTest.java is failing

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 15, 2021
@prsadhuk
Copy link
Contributor Author

@prsadhuk prsadhuk commented Apr 15, 2021

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@prsadhuk Pushed as commit b72d99e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8233564 branch Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants