8265120: hs_err improvement: align the output of Virtual space metadata

[frank-king]

In the "virtual space" section of the VM error log, the "Both" line doesn't align well will the above two lines - there is a redundant leading space in this line.

Metaspace:

Usage:
  Non-class:    216.95 KB used.
      Class:     10.45 KB used.
       Both:    227.40 KB used.

Virtual space:
  Non-class space:        8.00 MB reserved,     320.00 KB (  4%) committed,  1 nodes.
      Class space:        1.00 GB reserved,     128.00 KB ( <1%) committed,  1 nodes.
              Both:        1.01 GB reserved,     448.00 KB ( <1%) committed.     <---- Not aligned here

It can be simply fixed by removing the redundant space in function print_vs in src/hotspot/share/memory/metaspace/metaspaceReporter.cpp.

Here is the fixed result:

Metaspace:

Usage:
  Non-class:    216.95 KB used.
      Class:     10.45 KB used.
       Both:    227.40 KB used.

Virtual space:
  Non-class space:        8.00 MB reserved,     320.00 KB (  4%) committed,  1 nodes.
      Class space:        1.00 GB reserved,     128.00 KB ( <1%) committed,  1 nodes.
             Both:        1.01 GB reserved,     448.00 KB ( <1%) committed.    <----- Fixed

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265120: hs_err improvement: align the output of Virtual space metadata

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3458/head:pull/3458
$ git checkout pull/3458

Update a local copy of the PR:
$ git checkout pull/3458
$ git pull https://git.openjdk.java.net/jdk pull/3458/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3458

View PR using the GUI difftool:
$ git pr show -t 3458

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3458.diff

[bridgekeeper]

Hi @whjpji, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user whjpji" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

⚠️ @whjpji a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master f2f7aa3becd379612a22d46f4cdf0a6107e4119c
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

[openjdk]

@whjpji The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[frank-king]

/covered

[frank-king]

/covered junjiwang@tencent.com

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 00: Full (50f793c7)

[dholmes-ora]

This is a trivial fix. I will sponsor this for you.

Thanks,
David

[openjdk]

⚠️ @whjpji the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout master
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@whjpji This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265120: hs_err improvement: align the output of Virtual space metadata

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 5931948: 8265246: Fix macos-Aarch64 build after JDK-8263709
• 79bff21: 8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines
• f4c3efd: 8265192: [macos_aarch64] configure script fails if GNU uname in PATH
• e167577: 8265078: jpackage tests on Windows leave large temp files
• 05f851e: 8265236: ProblemList java/foreign/TestUpcall.java on macosx-aarch64
• d1b28e7: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
• 57f86a0: 8265235: ProblemList java/foreign/TestIntrinsics.java on macosx-aarch64
• 4c83d24: 8058176: [mlvm] tests should not allow code cache exhaustion
• 9406744: 8264976: Minor numeric bug in AbstractSplittableWithBrineGenerator.makeSplitsSpliterator
• 80026d8: 8265174: Update Class.getDeclaredMethods to discuss synthetic and bridge methods
• ... and 28 more: https://git.openjdk.java.net/jdk/compare/f2f7aa3becd379612a22d46f4cdf0a6107e4119c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[frank-king]

/integrate

[openjdk]

@whjpji
Your change (at version 50f793c) is now ready to be sponsored by a Committer.

[frank-king]

This is a trivial fix. I will sponsor this for you.

Thanks,
David

Thanks @dholmes-ora !

[dholmes-ora]

/sponsor

[openjdk]

@dholmes-ora @whjpji Since your change was applied there have been 39 commits pushed to the master branch:

• e7cbeba: 8259070: Add jcmd option to dump CDS
• 5931948: 8265246: Fix macos-Aarch64 build after JDK-8263709
• 79bff21: 8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines
• f4c3efd: 8265192: [macos_aarch64] configure script fails if GNU uname in PATH
• e167577: 8265078: jpackage tests on Windows leave large temp files
• 05f851e: 8265236: ProblemList java/foreign/TestUpcall.java on macosx-aarch64
• d1b28e7: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
• 57f86a0: 8265235: ProblemList java/foreign/TestIntrinsics.java on macosx-aarch64
• 4c83d24: 8058176: [mlvm] tests should not allow code cache exhaustion
• 9406744: 8264976: Minor numeric bug in AbstractSplittableWithBrineGenerator.makeSplitsSpliterator
• ... and 29 more: https://git.openjdk.java.net/jdk/compare/f2f7aa3becd379612a22d46f4cdf0a6107e4119c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7c6e379.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.