New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265125: IGV: cannot edit forms with NetBeans GUI builder #3461
Conversation
|
@robcasloz The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label remove build |
@robcasloz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trivial
@robcasloz This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
Thanks for reviewing, Vladimir! |
/integrate |
@robcasloz Since your change was applied there have been 11 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 8df8512. |
This change moves all NetBeans-generated .form files to the same directory as their corresponding Java source files. This allows NetBeans to recognize the corresponding Java source files as Swing forms, and open them in "Design" mode:
The .form files are only processed by NetBeans, so this change does not affect how IGV is built and run.
Tested manually by reproducing the steps in the JBS bug report and by checking that IGV can be built and run following the steps in IGV's README.md file.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3461/head:pull/3461
$ git checkout pull/3461
Update a local copy of the PR:
$ git checkout pull/3461
$ git pull https://git.openjdk.java.net/jdk pull/3461/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3461
View PR using the GUI difftool:
$ git pr show -t 3461
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3461.diff