8262108: SimpleDateFormat formatting broken for sq_MK Locale #3463
Can I please get a review for this proposed fix for https://bugs.openjdk.java.net/browse/JDK-8262108?
As noted in a comment in that issue, the bug relates to the return value of
The commit here adds a check in the internal implementation of the display name handling logic, to special case the
The commit also has a new jtreg test case
After this fix was introduced, I ran the test in
While we are at this, the
If I understand this correctly, if the
Hello @naotoj, my tier1 test run passed without issues locally with this change:
(the 4 hotspot failures are unrelated environmental issues).
After seeing your message, I now ran the
and even those passed.
I don't have much knowledge in this area of the code, but as far as I can see, this doesn't touch the changes introduced in the java.time to support the new day period construct.
Thanks for checking.
Thank you for those details. That's very helpful.
I've taken your suggestion and updated the code to match this. In the update, I've included a code comment to explain what this block does. Please do let me know if that code comment isn't accurate and needs any updates.
All jtreg tests in
Thank you for your reviews so far.
@jaikiran This change now passes all automated pre-integration checks.
After integration, the commit message for the final commit will be:
At the time when this comment was updated there had been 66 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
@jaikiran Since your change was applied there have been 66 commits pushed to the
Your commit was automatically rebased without conflicts.
Pushed as commit 64e2130.