8257836: Add additional test cases to TestSyncOnValueBasedClassEvent.java

[hseigel]

Please review this small change to add additional test cases to TestSyncOnValueBasedClassEvent.java. The modified test was tested using Mach5 on Linux x64, Linux aarch64, Mac OS and Windows.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257836: Add additional test cases to TestSyncOnValueBasedClassEvent.java

Reviewers

• Lois Foltan (@lfoltan - Reviewer)
• Patricio Chilano Mateo (@pchilano - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3465/head:pull/3465
$ git checkout pull/3465

Update a local copy of the PR:
$ git checkout pull/3465
$ git pull https://git.openjdk.java.net/jdk pull/3465/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3465

View PR using the GUI difftool:
$ git pr show -t 3465

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3465.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[hseigel]

/label add hotspot-runtime

[openjdk]

@hseigel
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (1125f1f1)

[lfoltan]

Looks good.
Lois

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257836: Add additional test cases to TestSyncOnValueBasedClassEvent.java

Reviewed-by: lfoltan, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 8df8512: 8265125: IGV: cannot edit forms with NetBeans GUI builder
• 9cd5400: 8265138: Simplify DerUtils::checkAlg
• c797511: 8264940: java/lang/invoke/6998541/Test6998541.java failed "guarantee(ik->is_initialized()) failed: java/lang/Byte$ByteCache must be initialized"
• 943503e: 8265035: Remove unneeded exception check from refill_ic_stubs()
• fced0f0: 8265113: ProblemList gtest/GTestWrapper.java:os.release_multi_mappings on macosx-aarch64
• 2aae29c: 8265111: ProblemList java/util/concurrent/locks/Lock/TimedAcquireLeak.java on macosx-aarch64
• a84d886: 8265112: ProblemList some java/foreign tests on macosx-aarch64
• 87e39cb: 8265110: ProblemList compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java on macosx-aarch64
• 784f1c1: 8264200: java/nio/channels/DatagramChannel/SRTest.java fails intermittently

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[pchilano]

LGTM!

Thanks,
Patricio

[hseigel]

Thanks Lois and Patricio for reviewing this.

/integrate

[openjdk]

@hseigel Since your change was applied there have been 18 commits pushed to the master branch:

• 27dd88b: 8262957: (fs) Fail fast in UnixFileStore.isExtendedAttributesEnabled
• e2106d5: 8265104: CpuLoad and SystemCpuLoad in OperatingSystem MXBean returns -1.0
• ebbce91: 8264681: Use the blessed modifier order in java.security
• ea5c55a: 8265103: Remove unnecessary inclusion of oopMap.hpp
• 26186ec: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
• 283d64f: 8262896: [macos_aarch64] Crash in jni_fast_GetLongField
• 55d5649: 8263157: [macos]: java.library.path is being set incorrectly
• e80012e: 8264768: JFR: Allow events to be printed to the log
• 3b576ed: 8265100: (fs) WindowsFileStore.hashCode() should read cached hash code once
• 8df8512: 8265125: IGV: cannot edit forms with NetBeans GUI builder
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/a4f644eb2f0bfd3a817ca40f87f434bfd1030732...master

Your commit was automatically rebased without conflicts.

Pushed as commit f5b2f08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.