-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8257836: Add additional test cases to TestSyncOnValueBasedClassEvent.java #3465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into |
/label add hotspot-runtime |
@hseigel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Lois
@hseigel This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks,
Patricio
Thanks Lois and Patricio for reviewing this. /integrate |
@hseigel Since your change was applied there have been 18 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f5b2f08. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this small change to add additional test cases to TestSyncOnValueBasedClassEvent.java. The modified test was tested using Mach5 on Linux x64, Linux aarch64, Mac OS and Windows.
Thanks, Harold
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3465/head:pull/3465
$ git checkout pull/3465
Update a local copy of the PR:
$ git checkout pull/3465
$ git pull https://git.openjdk.java.net/jdk pull/3465/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3465
View PR using the GUI difftool:
$ git pr show -t 3465
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3465.diff