Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out #3466

Closed
wants to merge 2 commits into from

Conversation

fguallini
Copy link
Member

@fguallini fguallini commented Apr 13, 2021

test/jdk/javax/net/ssl/DTLS/RespondToRetransmit.java has been seen to fail intermittently.
The server side is binding to the wildcard/localhost address which has been a source of instability in many tests. Binding to loopback address fixes the intermittent failures.

In addition, other changes were introduced in the tests to improve code readability:

  • Reduce duplication by reusing code
  • Replace if statements with Switch expressions
  • Make fields final when appropriate
  • Convert ServerCallable and ClientCallable to records
  • Replace Byte.valueOf with Byte.parseByte to avoid redundant boxing

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3466/head:pull/3466
$ git checkout pull/3466

Update a local copy of the PR:
$ git checkout pull/3466
$ git pull https://git.openjdk.java.net/jdk pull/3466/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3466

View PR using the GUI difftool:
$ git pr show -t 3466

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3466.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2021

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 13, 2021
@openjdk
Copy link

openjdk bot commented Apr 13, 2021

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Apr 13, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 13, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 13, 2021

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the master branch:

  • b72d99e: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • 2b5869a: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS
  • bba16f6: 8264818: G1: Improve liveness check for empty pinned regions after full gc marking
  • 75da1e9: 8264423: G1: Rename full gc attribute table states
  • 125a847: 8264788: Make SequentialSubTasksDone use-once
  • 0793fcb: 8260255: C1: LoopInvariantCodeMotion constructor can leave some fields uninitialized
  • b224b56: 8265225: jdk/jfr/tool/TestConfigure.java fails to cleanup the output files after the testing
  • 7c6e379: 8265120: hs_err improvement: align the output of Virtual space metadata
  • e7cbeba: 8259070: Add jcmd option to dump CDS
  • 5931948: 8265246: Fix macos-Aarch64 build after JDK-8263709
  • ... and 110 more: https://git.openjdk.java.net/jdk/compare/eab84554e82923004921b2cce1be99fabb81ecc8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@XueleiFan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2021
@fguallini
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@fguallini
Your change (at version 5ccfd21) is now ready to be sponsored by a Committer.

@XueleiFan
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Apr 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@XueleiFan @fguallini Since your change was applied there have been 153 commits pushed to the master branch:

  • 1c3fd46: 8265175: (fs) Files.copy(Path,Path,CopyOption...) should use sendfile on Linux
  • cee4f1d: 8203925: tools/javac/importscope/T8193717.java ran out of java heap
  • 694e1cd: 8262060: compiler/whitebox/BlockingCompilation.java timed out
  • 6946d91: 8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF
  • 714298a: 8265259: G1: Fix HeapRegion::block_is_obj for unloading class in full gc
  • ff5bb8c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
  • 17b6592: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
  • 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
  • 7137328: 8264958: C2 compilation fails with assert "n is later than its clone"
  • 1d66a15: 8265330: G1: Fix comment in G1FullGCPrepareTask::G1CalculatePointersClosure
  • ... and 143 more: https://git.openjdk.java.net/jdk/compare/eab84554e82923004921b2cce1be99fabb81ecc8...master

Your commit was automatically rebased without conflicts.

Pushed as commit 79adc16.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants