Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253426: jpackage is unable to generate working EXE for add-launcher configurations #347

Closed
wants to merge 3 commits into from

Conversation

@andyherrick
Copy link

@andyherrick andyherrick commented Sep 24, 2020

8253426: jpackage is unable to generate working EXE for add-launcher configurations.
secondary launchers ignored module, main-jar, and main-class in launcher properties file because the LAUNCHER_DATA param was not removed from the set of params for each new add-module.
testcase added in AddLauncherTest,java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253426: jpackage is unable to generate working EXE for add-launcher configurations

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/347/head:pull/347
$ git checkout pull/347

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2020

👋 Welcome back herrick! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@andyherrick The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the core-libs label Sep 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2020

Webrevs

@andyherrick andyherrick marked this pull request as draft Sep 24, 2020
@openjdk openjdk bot removed the rfr label Sep 24, 2020
@andyherrick andyherrick marked this pull request as ready for review Sep 25, 2020
@openjdk openjdk bot added the rfr label Sep 25, 2020
Copy link
Member

@azuev-java azuev-java left a comment

Looks fine.

@andyherrick
Copy link
Author

@andyherrick andyherrick commented Oct 5, 2020

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@andyherrick This PR has not yet been marked as ready for integration.

@andyherrick andyherrick changed the title 8253426: jpackage is unable to generate working EXE for add-launcher … 8253426: jpackage is unable to generate working EXE for add-launcher configurations. Oct 5, 2020
@andyherrick andyherrick changed the title 8253426: jpackage is unable to generate working EXE for add-launcher configurations. 8253426: jpackage is unable to generate working EXE for add-launcher configurations Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@andyherrick This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253426: jpackage is unable to generate working EXE for add-launcher configurations

Reviewed-by: almatvee, kizune, asemenyuk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 190 new commits pushed to the master branch:

  • c9d0407: 8253794: TestAbortVMOnSafepointTimeout never timeouts
  • f2f77f7: 8253761: Wrong URI syntax printed by jar --describe-module
  • b29e108: 8253944: Certain method references to VarHandle methods should fail
  • 88d75c9: 8156071: List.of: reduce array copying during creation
  • ea27a54: 8224509: Incorrect alignment in CDS related allocation code on 32-bit platforms
  • 4d29116: 8253433: Remove -XX:+Debugging product option
  • 81dae70: 8253948: Memory leak in ImageFileReader
  • 65cab55: 8253971: ZGC: Flush mark stacks after processing concurrent roots
  • 19219a9: 8253960: Memory leak in Java_java_lang_ClassLoader_defineClass0()
  • 5d4a135: 8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers.
  • ... and 180 more: https://git.openjdk.java.net/jdk/compare/43be5a3cb65d5c8165d9493f56b24c921c40cff3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 5, 2020
@andyherrick
Copy link
Author

@andyherrick andyherrick commented Oct 5, 2020

/integrate

@openjdk openjdk bot closed this Oct 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2020

@andyherrick Since your change was applied there have been 190 commits pushed to the master branch:

  • c9d0407: 8253794: TestAbortVMOnSafepointTimeout never timeouts
  • f2f77f7: 8253761: Wrong URI syntax printed by jar --describe-module
  • b29e108: 8253944: Certain method references to VarHandle methods should fail
  • 88d75c9: 8156071: List.of: reduce array copying during creation
  • ea27a54: 8224509: Incorrect alignment in CDS related allocation code on 32-bit platforms
  • 4d29116: 8253433: Remove -XX:+Debugging product option
  • 81dae70: 8253948: Memory leak in ImageFileReader
  • 65cab55: 8253971: ZGC: Flush mark stacks after processing concurrent roots
  • 19219a9: 8253960: Memory leak in Java_java_lang_ClassLoader_defineClass0()
  • 5d4a135: 8253842: [JVMCI] Allow implicit exception to dispatch to other address in jvmci compilers.
  • ... and 180 more: https://git.openjdk.java.net/jdk/compare/43be5a3cb65d5c8165d9493f56b24c921c40cff3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4fe68f5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andyherrick andyherrick deleted the andyherrick:JDK-8253426 branch Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants