8265019 : Update tests for additional TestNG test permissions #3471

LanceAndersen · 2021-04-13T18:01:49Z

Hi all,

Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.

Best,
Lance

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265019: Update tests for additional TestNG test permissions

Reviewers

Naoto Sato (@naotoj - Reviewer) ⚠️ Review applies to 20ef2bd
Brian Burkhalter (@bplb - Reviewer) ⚠️ Review applies to 20ef2bd
Alan Bateman (@AlanBateman - Reviewer) ⚠️ Review applies to 20ef2bd

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3471/head:pull/3471
$ git checkout pull/3471

Update a local copy of the PR:
$ git checkout pull/3471
$ git pull https://git.openjdk.java.net/jdk pull/3471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3471

View PR using the GUI difftool:
$ git pr show -t 3471

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3471.diff

bridgekeeper · 2021-04-13T18:02:59Z

👋 Welcome back lancea! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-04-13T18:04:58Z

@LanceAndersen The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-04-13T18:17:18Z

Webrevs

AlanBateman · 2021-04-13T18:34:52Z

test/jdk/java/lang/ProcessHandle/PermissionTest.java

+        permissions.add(new PropertyPermission("testng.mode.dryrun", "read"));
+        permissions.add(new PropertyPermission("testng.report.xml.name", "read"));
+        permissions.add(new ReflectPermission("suppressAccessChecks"));
+        permissions.add(new PropertyPermission("testng.timezone", "read"));


might be better to group the testng.* properties so they aren't mixed up with the other runtime permissions.

naotoj

Looks good.

openjdk · 2021-04-13T21:34:28Z

@LanceAndersen This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265019: Update tests for additional TestNG test permissions

Reviewed-by: naoto, bpb, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

27dd88b: 8262957: (fs) Fail fast in UnixFileStore.isExtendedAttributesEnabled
e2106d5: 8265104: CpuLoad and SystemCpuLoad in OperatingSystem MXBean returns -1.0
ebbce91: 8264681: Use the blessed modifier order in java.security
ea5c55a: 8265103: Remove unnecessary inclusion of oopMap.hpp
26186ec: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
283d64f: 8262896: [macos_aarch64] Crash in jni_fast_GetLongField
55d5649: 8263157: [macos]: java.library.path is being set incorrectly
e80012e: 8264768: JFR: Allow events to be printed to the log
3b576ed: 8265100: (fs) WindowsFileStore.hashCode() should read cached hash code once
8df8512: 8265125: IGV: cannot edit forms with NetBeans GUI builder

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

AlanBateman · 2021-04-14T06:10:45Z

test/jdk/java/sql/testng/util/TestPolicy.java

-import java.security.ProtectionDomain;
-import java.security.SecurityPermission;
+import java.lang.reflect.ReflectPermission;
+import java.security.*;


My guess is that you didn't mean the change the import.

mlbridge · 2021-04-14T10:25:59Z

Mailing list message from Lance Andersen on core-libs-dev:

On Apr 14, 2021, at 2:13 AM, Alan Bateman <alanb at openjdk.java.net<mailto:alanb at openjdk.java.net>> wrote:

On Tue, 13 Apr 2021 18:56:22 GMT, Lance Andersen <lancea at openjdk.org<mailto:lancea at openjdk.org>> wrote:

Hi all,

Please review the following patch which adds additional permissions needed for when JTREG upgrades to a newer version of TestNG.

Best,
Lance

Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:

TestNG updates Permission re-organization

Marked as reviewed by alanb (Reviewer).

test/jdk/java/sql/testng/util/TestPolicy.java line 27:

25: import java.io.FilePermission;
26: import java.lang.reflect.ReflectPermission;
27: import java.security.*;

My guess is that you didn't mean the change the import.

Intellij did that automagically. I just reverted the change for consistency

-------------

PR: https://git.openjdk.java.net/jdk/pull/3471

[cid:E1C4E2F0-ECD0-4C9D-ADB4-B16CA7BCB7FC at home]

Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>

LanceAndersen · 2021-04-14T15:42:04Z

/integrate

openjdk · 2021-04-14T15:43:14Z

@LanceAndersen Since your change was applied there have been 15 commits pushed to the master branch:

7e4cd48: 8264821: DirectIOTest fails on a system with large block size
0afcbd4: 8264412: AArch64: CPU description should refer DMI
4661690: 8262883: doccheck: Broken links in java.base
75b039a: 8263970: Manual test javax/swing/JTextField/JapaneseReadingAttributes/JapaneseReadingAttributes.java failed
f5b2f08: 8257836: Add additional test cases to TestSyncOnValueBasedClassEvent.java
27dd88b: 8262957: (fs) Fail fast in UnixFileStore.isExtendedAttributesEnabled
e2106d5: 8265104: CpuLoad and SystemCpuLoad in OperatingSystem MXBean returns -1.0
ebbce91: 8264681: Use the blessed modifier order in java.security
ea5c55a: 8265103: Remove unnecessary inclusion of oopMap.hpp
26186ec: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
... and 5 more: https://git.openjdk.java.net/jdk/compare/9cd5400d9b2fd80baf618b48890dd9d6fe13eee2...master

Your commit was automatically rebased without conflicts.

Pushed as commit ffb3771.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

TestNG updates

0183f88

openjdk bot added the core-libs core-libs-dev@openjdk.org label Apr 13, 2021

LanceAndersen changed the title ~~Update tests for additional TestNG test permissions~~ 8265019 : Update tests for additional TestNG test permissions Apr 13, 2021

openjdk bot added the rfr Pull request is ready for review label Apr 13, 2021

AlanBateman reviewed Apr 13, 2021

View reviewed changes

TestNG updates Permission re-organization

20ef2bd

naotoj approved these changes Apr 13, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2021

bplb approved these changes Apr 13, 2021

View reviewed changes

AlanBateman approved these changes Apr 14, 2021

View reviewed changes

Add back individual security imports

31edda8

openjdk bot closed this Apr 14, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Apr 14, 2021

openjdk bot removed the rfr Pull request is ready for review label Apr 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8265019 : Update tests for additional TestNG test permissions #3471

8265019 : Update tests for additional TestNG test permissions #3471

LanceAndersen commented Apr 13, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

mlbridge bot commented Apr 13, 2021 •

edited

Loading

AlanBateman Apr 13, 2021

naotoj left a comment

openjdk bot commented Apr 13, 2021 •

edited

Loading

AlanBateman Apr 14, 2021

mlbridge bot commented Apr 14, 2021

LanceAndersen commented Apr 14, 2021

openjdk bot commented Apr 14, 2021

8265019 : Update tests for additional TestNG test permissions #3471

8265019 : Update tests for additional TestNG test permissions #3471

Conversation

LanceAndersen commented Apr 13, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Apr 13, 2021

openjdk bot commented Apr 13, 2021

mlbridge bot commented Apr 13, 2021 • edited Loading

Webrevs

AlanBateman Apr 13, 2021

Choose a reason for hiding this comment

naotoj left a comment

Choose a reason for hiding this comment

openjdk bot commented Apr 13, 2021 • edited Loading

AlanBateman Apr 14, 2021

Choose a reason for hiding this comment

mlbridge bot commented Apr 14, 2021

LanceAndersen commented Apr 14, 2021

openjdk bot commented Apr 14, 2021

LanceAndersen commented Apr 13, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 13, 2021 •

edited

Loading

openjdk bot commented Apr 13, 2021 •

edited

Loading