-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8265078: jpackage tests on Windows leave large temp files #3473
Conversation
👋 Welcome back herrick! A progress list of the required criteria for merging this PR into |
@andyherrick The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java
Outdated
Show resolved
Hide resolved
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java
Outdated
Show resolved
Hide resolved
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you need an AtomicReference
to set the exception? I don't see any use of multiple threads, but I might be missing something. If you do need it, you need to fix the order of arguments.
src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. I see that this bug is listed as Windows-specific. Are any similar changes needed for other platforms, or do they already write test files only to java.io.tmpdir
?
Although jpackage failing to clean up has only been seen as an issue on Windows, allowing it to write outside the test directory (in default tmp dir) still exists on mac and linux - I will look into enhancing (what is now setWindowsTmpDir()) to be usefull on all platforms. |
|
@andyherrick This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 83 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
I don't think they can.
Given that the Still, I think using |
/integrate |
@andyherrick Since your change was applied there have been 86 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit e167577. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
two changes:
One to jpackage, when recursively removing directory, when IOException occurs, record it and continue (deleting as much as possible) before throwing the exception.
The other to tests, when running jpackage via ProcessBuilder.execute(), set the "TMP" environment variable to the current value of System Property "java.io.tmpdir". This causes the sub-process (jpackage) to output tmp files to the tmp file location used by the test. (So the test harness can clean up after test exits).
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3473/head:pull/3473
$ git checkout pull/3473
Update a local copy of the PR:
$ git checkout pull/3473
$ git pull https://git.openjdk.java.net/jdk pull/3473/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3473
View PR using the GUI difftool:
$ git pr show -t 3473
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3473.diff