8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF

[azvegint]

This manual test was written for Metal L&F, so now it is set explicitly.
Test is also refactored to use JFrame instead of Applet.

The test is not in ProblemList.txt.
It still fails on JDK 1.5 (after removing all syntactic sugar).

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer) ⚠️ Review applies to f804ee1
• Alexander Zuev (@azuev-java - Reviewer) ⚠️ Review applies to 86c154a
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3474/head:pull/3474
$ git checkout pull/3474

Update a local copy of the PR:
$ git checkout pull/3474
$ git pull https://git.openjdk.java.net/jdk pull/3474/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3474

View PR using the GUI difftool:
$ git pr show -t 3474

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3474.diff

[bridgekeeper]

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azvegint The following label will be automatically applied to this pull request:

• swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (ad54c65f)
• 04: Full - Incremental (e46bd17a)
• 03: Full - Incremental (86c154a2)
• 02: Full - Incremental (f804ee19)
• 01: Full - Incremental (6c7457d3)
• 00: Full (4a8b55a1)

[prsadhuk]

I see RadioButton and RBMenuItem check mark is not visible...so probably there is still a product bug somewhere...I guess we need to fix that as well when we fix this test..

[azvegint]

I see RadioButton and RBMenuItem check mark is not visible...so probably there is still a product bug somewhere...I guess we need to fix that as well when we fix this test..

Actually it is clearly visible. You can click on it to see the difference between checked/unchecked state.
Probably you are referring to a circle shape of "check mark", but that is correct shape.

Here is a comparison of JDK17 vs JDK5 (all components are in selected state).

JDK17

JDK5

JDK17

JDK5

JDK5 clearly failed this test.

[prsadhuk]

I am referring to check mark only, not the shape...I could see the white visible selected checkmark(circular) for RadioButton when "Ocean Theme" is not selected but when "Ocean Theme" is selected, black checkmark over black background is not visible.

Also, the original bug 4449413 does not talk about Metal. It seems the issue is seen only in Metal but that should not prevent us from running in all L&Fs.

[azvegint]

I am referring to check mark only, not the shape...I could see the white visible selected checkmark(circular) for RadioButton when "Ocean Theme" is not selected but when "Ocean Theme" is selected, black checkmark over black background is not visible.

This black check mark does have a light colored halo around which helps to see it.

Here is an example of radio button usage in group:

I definitely can see which one is selected. So I do not see issue here.

Also, the original bug 4449413 does not talk about Metal. It seems the issue is seen only in Metal but that should not prevent us from running in all L&Fs.

Updated to allow it to run with other L&Fs.

Please see below screenshots with other L&Fs applied. Some of them controversial, but I prefer to file a new bugs for them if any.

(Labels for disabled text is not visible, but MotifLookAndFeel is marked for removal, so probably it is not worth to fix it.)

[openjdk]

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF

Reviewed-by: psadhukhan, kizune, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

• 714298a: 8265259: G1: Fix HeapRegion::block_is_obj for unloading class in full gc
• ff5bb8c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
• 17b6592: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
• 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
• 7137328: 8264958: C2 compilation fails with assert "n is later than its clone"
• 1d66a15: 8265330: G1: Fix comment in G1FullGCPrepareTask::G1CalculatePointersClosure
• b4ba74e: 8264987: G1: Fill BOTs for Survivor-turned-to-Old regions in full gc
• fc89fe6: 8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes
• 50f3da8: 8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG
• e0151a6: 8264104: Eliminate unnecessary vector mask conversion during VectorUnbox for floating point VectorMask
• ... and 72 more: https://git.openjdk.java.net/jdk/compare/d84a7e55be40eae57b6c322694d55661a5053a55...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[azvegint]

I've also replaced text blocks with string literals to ease backporting.

[azvegint]

/integrate

[openjdk]

@azvegint Since your change was applied there have been 82 commits pushed to the master branch:

• 714298a: 8265259: G1: Fix HeapRegion::block_is_obj for unloading class in full gc
• ff5bb8c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
• 17b6592: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
• 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
• 7137328: 8264958: C2 compilation fails with assert "n is later than its clone"
• 1d66a15: 8265330: G1: Fix comment in G1FullGCPrepareTask::G1CalculatePointersClosure
• b4ba74e: 8264987: G1: Fill BOTs for Survivor-turned-to-Old regions in full gc
• fc89fe6: 8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes
• 50f3da8: 8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG
• e0151a6: 8264104: Eliminate unnecessary vector mask conversion during VectorUnbox for floating point VectorMask
• ... and 72 more: https://git.openjdk.java.net/jdk/compare/d84a7e55be40eae57b6c322694d55661a5053a55...master

Your commit was automatically rebased without conflicts.

Pushed as commit 6946d91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.