Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265192: [macos_aarch64] configure script fails if GNU uname in PATH #3487

Closed
wants to merge 1 commit into from

Conversation

@nick-arm
Copy link
Member

@nick-arm nick-arm commented Apr 14, 2021

With GNU coreutils from Homebrew in the PATH, configure fails on Apple
silicon Macs with:

checking build system type... Invalid configuration `arm64-apple-darwin20.2.0': machine `arm64-apple' not recognized
configure: error: /opt/homebrew/bin/bash /Users/nicgas01/jdk/make/autoconf/build-aux/config.sub arm64-apple-darwin20.2.0 failed
configure exiting with result code 1

The system uname -p prints "arm" but GNU's version prints "arm64".
This patch just extends config.guess to handle this case.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265192: [macos_aarch64] configure script fails if GNU uname in PATH

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3487/head:pull/3487
$ git checkout pull/3487

Update a local copy of the PR:
$ git checkout pull/3487
$ git pull https://git.openjdk.java.net/jdk pull/3487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3487

View PR using the GUI difftool:
$ git pr show -t 3487

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3487.diff

With GNU coreutils from Homebrew in the PATH, configure fails on Apple
silicon Macs with:

  checking build system type... Invalid configuration `arm64-apple-darwin20.2.0': machine `arm64-apple' not recognized
  configure: error: /opt/homebrew/bin/bash /Users/nicgas01/jdk/make/autoconf/build-aux/config.sub arm64-apple-darwin20.2.0 failed
  configure exiting with result code 1

The system `uname -p` prints "arm" but GNU's version prints "arm64".
This patch just extends config.guess to handle this case.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 14, 2021

👋 Welcome back ngasson! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@nick-arm The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the build label Apr 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 14, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@nick-arm This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265192: [macos_aarch64] configure script fails if GNU uname in PATH

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f5b2f08: 8257836: Add additional test cases to TestSyncOnValueBasedClassEvent.java
  • 27dd88b: 8262957: (fs) Fail fast in UnixFileStore.isExtendedAttributesEnabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 14, 2021
@nick-arm
Copy link
Member Author

@nick-arm nick-arm commented Apr 15, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@nick-arm Since your change was applied there have been 14 commits pushed to the master branch:

  • e167577: 8265078: jpackage tests on Windows leave large temp files
  • 05f851e: 8265236: ProblemList java/foreign/TestUpcall.java on macosx-aarch64
  • d1b28e7: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
  • 57f86a0: 8265235: ProblemList java/foreign/TestIntrinsics.java on macosx-aarch64
  • 4c83d24: 8058176: [mlvm] tests should not allow code cache exhaustion
  • 9406744: 8264976: Minor numeric bug in AbstractSplittableWithBrineGenerator.makeSplitsSpliterator
  • 80026d8: 8265174: Update Class.getDeclaredMethods to discuss synthetic and bridge methods
  • ffb3771: 8265019: Update tests for additional TestNG test permissions
  • 7e4cd48: 8264821: DirectIOTest fails on a system with large block size
  • 0afcbd4: 8264412: AArch64: CPU description should refer DMI
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/e2106d5af6244a9394be10106619ea5ac3262a9a...master

Your commit was automatically rebased without conflicts.

Pushed as commit f4c3efd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants