Skip to content

8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Apr 14, 2021

This test NullModalityDialogTest.java was failing repeatedly on macos in automated testing citing "Tab navigation did not happen properly".
Modified to use invokeAndWait() instead of invokeLater and also use setAutoDelay() with appropriate delay time, in consistent with other automated tests running on mach5.
Several iterations of the test works fine in all platforms after this modification.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3488/head:pull/3488
$ git checkout pull/3488

Update a local copy of the PR:
$ git checkout pull/3488
$ git pull https://git.openjdk.java.net/jdk pull/3488/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3488

View PR using the GUI difftool:
$ git pr show -t 3488

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3488.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2021
@openjdk
Copy link

openjdk bot commented Apr 14, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Apr 14, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 14, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS

Reviewed-by: jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 75da1e9: 8264423: G1: Rename full gc attribute table states
  • 125a847: 8264788: Make SequentialSubTasksDone use-once
  • 0793fcb: 8260255: C1: LoopInvariantCodeMotion constructor can leave some fields uninitialized
  • b224b56: 8265225: jdk/jfr/tool/TestConfigure.java fails to cleanup the output files after the testing
  • 7c6e379: 8265120: hs_err improvement: align the output of Virtual space metadata
  • e7cbeba: 8259070: Add jcmd option to dump CDS
  • 5931948: 8265246: Fix macos-Aarch64 build after JDK-8263709
  • 79bff21: 8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines
  • f4c3efd: 8265192: [macos_aarch64] configure script fails if GNU uname in PATH
  • e167577: 8265078: jpackage tests on Windows leave large temp files
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/e2106d5af6244a9394be10106619ea5ac3262a9a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2021
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@prsadhuk Since your change was applied there have been 24 commits pushed to the master branch:

  • bba16f6: 8264818: G1: Improve liveness check for empty pinned regions after full gc marking
  • 75da1e9: 8264423: G1: Rename full gc attribute table states
  • 125a847: 8264788: Make SequentialSubTasksDone use-once
  • 0793fcb: 8260255: C1: LoopInvariantCodeMotion constructor can leave some fields uninitialized
  • b224b56: 8265225: jdk/jfr/tool/TestConfigure.java fails to cleanup the output files after the testing
  • 7c6e379: 8265120: hs_err improvement: align the output of Virtual space metadata
  • e7cbeba: 8259070: Add jcmd option to dump CDS
  • 5931948: 8265246: Fix macos-Aarch64 build after JDK-8263709
  • 79bff21: 8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines
  • f4c3efd: 8265192: [macos_aarch64] configure script fails if GNU uname in PATH
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/e2106d5af6244a9394be10106619ea5ac3262a9a...master

Your commit was automatically rebased without conflicts.

Pushed as commit 2b5869a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8233565 branch April 15, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants