Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253616: Change to GCC 10.2 for building on Linux at Oracle #349

Closed
wants to merge 2 commits into from

Conversation

@vidmik
Copy link
Contributor

@vidmik vidmik commented Sep 24, 2020

Please review this change which updates the defaults in the linux devkit creator, the doc/building.md file, and the JIB (Oracle) configuration to gcc 10.2.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253616: Change to GCC 10.2 for building on Linux at Oracle

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/349/head:pull/349
$ git checkout pull/349

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2020

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@vidmik The following label will be automatically applied to this pull request: build.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the build label Sep 24, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2020

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253616: Change to GCC 10.2 for building on Linux at Oracle

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 24, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@vidmik this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8253616-gcc-10.2.0
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added merge-conflict and removed ready labels Sep 25, 2020
@openjdk openjdk bot added ready and removed merge-conflict labels Sep 28, 2020
@vidmik
Copy link
Contributor Author

@vidmik vidmik commented Sep 28, 2020

/integrate

@openjdk openjdk bot closed this Sep 28, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2020

@vidmik Since your change was applied there have been 2 commits pushed to the master branch:

  • 821bd08: 8253667: ProblemList tools/jlink/JLinkReproducible{,3}Test.java on linux-aarch64
  • 1ae6b53: 8252194: Add automated test for fix done in JDK-8218469

Your commit was automatically rebased without conflicts.

Pushed as commit d25b03e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vidmik vidmik deleted the 8253616-gcc-10.2.0 branch Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants