-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8262883: doccheck: Broken links in java.base #3491
Conversation
👋 Welcome back michaelm! A progress list of the required criteria for merging this PR into |
@Michael-Mc-Mahon The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label add nio |
@Michael-Mc-Mahon |
@Michael-Mc-Mahon This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@Michael-Mc-Mahon Since your change was applied there have been 3 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 4661690. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@@ -172,7 +172,7 @@ public static DatagramChannel open() throws IOException { | |||
* java.nio.channels.spi.SelectorProvider} object. The channel will not be | |||
* connected. | |||
* | |||
* @apiNote <a href="package-summary.html#unixdomain">Unix domain</a> sockets | |||
* @apiNote {@linkplain java.net.UnixDomainSocketAddress Unix domain} sockets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter to this method is a ProtocolFamily and maybe this note should be say that StandardProtocolFamily#UNIX is not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, reasonable suggestion. I was a bit quick integrating. I will file a new issue to update the spec as suggested.
Integrating less than an hour after the PR is started seems to be a bit too quick to allow useful input. |
Hi,
Could I get the following trivial doc changes reviewed please, caused by:
broken tags in MethodHandles referring to package.html instead of package-summary.html
references to a package level #unixdomain anchor that no longer exists.
a tag missing a "../" in SocketChannel
Thanks,
Michael
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3491/head:pull/3491
$ git checkout pull/3491
Update a local copy of the PR:
$ git checkout pull/3491
$ git pull https://git.openjdk.java.net/jdk pull/3491/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3491
View PR using the GUI difftool:
$ git pr show -t 3491
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3491.diff