Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test #3492

Closed
wants to merge 1 commit into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Apr 14, 2021

The most recent intermittent failure showed that the error occurred during VM initialization.
Only the tty output was diverted, but not log output.
Add diversion of log output as well tty output.

Add -Xlog:all=warning:stderr and -Xlog:all=warning:stdout to correspond to
-XX:+DisplayVMOutputToStderr and -XX:+DisplayVMOutputToStdout


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3492/head:pull/3492
$ git checkout pull/3492

Update a local copy of the PR:
$ git checkout pull/3492
$ git pull https://git.openjdk.java.net/jdk pull/3492/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3492

View PR using the GUI difftool:
$ git pr show -t 3492

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3492.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 14, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 14, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Hi Roger,

The fix looks good, but it strikes me that any test using -XX:+DisplayVMOutputToXXX can potentially suffer from a similar problem e.g. (in this space):

test/jdk/java/lang/ProcessHandle/JavaChild.java

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 5931948: 8265246: Fix macos-Aarch64 build after JDK-8263709
  • 79bff21: 8263709: Cleanup THREAD/TRAPS/CHECK usage in JRT_ENTRY routines
  • f4c3efd: 8265192: [macos_aarch64] configure script fails if GNU uname in PATH
  • e167577: 8265078: jpackage tests on Windows leave large temp files
  • 05f851e: 8265236: ProblemList java/foreign/TestUpcall.java on macosx-aarch64
  • d1b28e7: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
  • 57f86a0: 8265235: ProblemList java/foreign/TestIntrinsics.java on macosx-aarch64
  • 4c83d24: 8058176: [mlvm] tests should not allow code cache exhaustion
  • 9406744: 8264976: Minor numeric bug in AbstractSplittableWithBrineGenerator.makeSplitsSpliterator
  • 80026d8: 8265174: Update Class.getDeclaredMethods to discuss synthetic and bridge methods
  • ... and 13 more: https://git.openjdk.java.net/jdk/compare/e80012ede3564a868abc1705f332bcee942baf48...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 15, 2021
@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented Apr 15, 2021

I checked the other uses of -XX:+Display... and they work as intended.
Thanks

@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented Apr 15, 2021

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@RogerRiggs Since your change was applied there have been 40 commits pushed to the master branch:

  • 4e90d74: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI
  • 6293299: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
  • 6b90715: 8265278: doc build fails after JDK-8262981
  • 0fee6ec: 8264318: Lanai: DrawHugeImageTest.java fails on apple M1
  • 81877f7: 8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt
  • b23dbdb: 8257804: Test runtime/modules/ModuleStress/ModuleStressGC.java fails: 'package test defined in module jdk.test, exports list being walked' missing from stdout/stderr
  • 9d669c9: 8262981: Create implementation for NSAccessibilitySlider protocol
  • abdff79: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails
  • b72d99e: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • 2b5869a: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS
  • ... and 30 more: https://git.openjdk.java.net/jdk/compare/e80012ede3564a868abc1705f332bcee942baf48...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7b61a42.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8265173-log-redirect branch Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs integrated
2 participants