8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

[bplb]

Please review this request to fix a test build failure caused by removing the isDirectIOSupportedByFS() method from the test DirectIOTest but not removing its use in other tests.

This also addresses the comment [1] in PR [2] of [3].

[1] #3482 (comment)
[2] #3482
[3] https://bugs.openjdk.java.net/browse/JDK-8264821

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• Joe Darcy (@jddarcy - Reviewer)
• Chris Hegarty (@ChrisHegarty - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3498/head:pull/3498
$ git checkout pull/3498

Update a local copy of the PR:
$ git checkout pull/3498
$ git pull https://git.openjdk.java.net/jdk pull/3498/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3498

View PR using the GUI difftool:
$ git pr show -t 3498

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3498.diff

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5531a429)

[dcubed-ojdk]

Thumbs up!

This is a trivial fix and does not need to wait 24 hours.
I sanity checked by searching the repo for isDirectIOSupportedByFS
and you've gotten the only remaining references.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Reviewed-by: alanb, dcubed, darcy, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 57f86a0: 8265235: ProblemList java/foreign/TestIntrinsics.java on macosx-aarch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/interate

[openjdk]

@bplb Unknown command interate - for a list of valid commands use /help.

[dcubed-ojdk]

I don't think the bots will let me do this but:

/integrate

[openjdk]

@dcubed-ojdk Only the author (@bplb) is allowed to issue the integrate command.

[bplb]

/integrate

[openjdk]

@bplb Since your change was applied there has been 1 commit pushed to the master branch:

• 57f86a0: 8265235: ProblemList java/foreign/TestIntrinsics.java on macosx-aarch64

Your commit was automatically rebased without conflicts.

Pushed as commit d1b28e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.