Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258794: Support for CLDR version 39 #3502

Closed
wants to merge 2 commits into from
Closed

8258794: Support for CLDR version 39 #3502

wants to merge 2 commits into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Apr 14, 2021

Please review the changes to support CLDR version 39. The vast majority of the changes are purely data changes from Unicode. The only change affected in logic was in CLDRLocaleProviderAdapter.java, where it needed to deal with CLDR's Norwegian language code switch (https://unicode-org.atlassian.net/browse/CLDR-2698)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3502/head:pull/3502
$ git checkout pull/3502

Update a local copy of the PR:
$ git checkout pull/3502
$ git pull https://git.openjdk.java.net/jdk pull/3502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3502

View PR using the GUI difftool:
$ git pr show -t 3502

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3502.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 14, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 14, 2021

Webrevs

Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Naoto, are you testing GitHub ('s ability to handle a large number of files) ;-)

Indeed, the majority changes were version and copyright. If you hadn't mentioned the changed class, it would be almost impossible to find it :-)

@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258794: Support for CLDR version 39

Reviewed-by: joehw, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 14, 2021
@naotoj
Copy link
Member Author

@naotoj naotoj commented Apr 14, 2021

Thanks, Joe.

Naoto, are you testing GitHub ('s ability to handle a large number of files) ;-)

CLDR itself has been hosted on GitHub too, so it shouldn't be a problem 🙂

@naotoj
Copy link
Member Author

@naotoj naotoj commented Apr 15, 2021

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@naotoj Since your change was applied there have been 28 commits pushed to the master branch:

  • e89fd15: 8261301: StringWriter.flush() is NOOP but documentation does not indicate it
  • 0b1b5c8: 8264373: javac hangs when annotation is declared with sealed public modifier
  • c7da64a: 8265302: ProblemList runtime/logging/RedefineClasses.java on linux-x64 -Xcomp
  • 838c11f: 8265293: ProblemList java/foreign/TestDowncall.java on macosx-aarch64
  • 325eecb: 8255273: jshell crashes with UnsupportedOperationException: Should not get here.
  • e43aee5: 8262900: ToolBasicTest fails to access HTTP server it starts
  • c70589c: 8265227: Move Proc.java from security/testlibrary to test/lib
  • 7b61a42: 8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test
  • 4e90d74: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI
  • 6293299: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
  • ... and 18 more: https://git.openjdk.java.net/jdk/compare/e167577888b8203001b1fc516ed382bc2a96c7b9...master

Your commit was automatically rebased without conflicts.

Pushed as commit f6e54f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants