8258794: Support for CLDR version 39#3502
Conversation
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
JoeWang-Java
left a comment
There was a problem hiding this comment.
Naoto, are you testing GitHub ('s ability to handle a large number of files) ;-)
Indeed, the majority changes were version and copyright. If you hadn't mentioned the changed class, it would be almost impossible to find it :-)
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Thanks, Joe.
CLDR itself has been hosted on GitHub too, so it shouldn't be a problem 🙂 |
|
/integrate |
|
@naotoj Since your change was applied there have been 28 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f6e54f2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review the changes to support CLDR version 39. The vast majority of the changes are purely data changes from Unicode. The only change affected in logic was in
CLDRLocaleProviderAdapter.java, where it needed to deal with CLDR's Norwegian language code switch (https://unicode-org.atlassian.net/browse/CLDR-2698)Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3502/head:pull/3502$ git checkout pull/3502Update a local copy of the PR:
$ git checkout pull/3502$ git pull https://git.openjdk.java.net/jdk pull/3502/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3502View PR using the GUI difftool:
$ git pr show -t 3502Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3502.diff