Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt #3503

Closed
wants to merge 2 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Apr 14, 2021

The fix for JDK-8246112 put the -lrt link flag in the wrong place, causing it to appear too early in the linker command-line. This changes puts it in the right place.

Contributed by: Matthias Klose (~doko)

Testing:

  • local testing by Matthias
  • tiers 1-3
  • GHA builds

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt

Reviewers

Contributors

  • Matthias Klose <doko@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3503/head:pull/3503
$ git checkout pull/3503

Update a local copy of the PR:
$ git checkout pull/3503
$ git pull https://git.openjdk.java.net/jdk pull/3503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3503

View PR using the GUI difftool:
$ git pr show -t 3503

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3503.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dholmes-ora
Copy link
Member Author

/contributor add @doko42

@openjdk
Copy link

openjdk bot commented Apr 14, 2021

@dholmes-ora Could not parse @doko42 as a valid contributor.
Syntax: /contributor (add|remove) [@user | openjdk-user | Full Name <email@address>]. For example:

  • /contributor add @openjdk-bot
  • /contributor add duke
  • /contributor add J. Duke <duke@openjdk.org>

@openjdk
Copy link

openjdk bot commented Apr 14, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 14, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 14, 2021
@dholmes-ora
Copy link
Member Author

/contributor add doko

@openjdk
Copy link

openjdk bot commented Apr 14, 2021

@dholmes-ora
Contributor Matthias Klose <doko@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Apr 14, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt

Co-authored-by: Matthias Klose <doko@openjdk.org>
Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • b23dbdb: 8257804: Test runtime/modules/ModuleStress/ModuleStressGC.java fails: 'package test defined in module jdk.test, exports list being walked' missing from stdout/stderr
  • 9d669c9: 8262981: Create implementation for NSAccessibilitySlider protocol
  • abdff79: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails
  • b72d99e: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • 2b5869a: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS
  • bba16f6: 8264818: G1: Improve liveness check for empty pinned regions after full gc marking
  • 75da1e9: 8264423: G1: Rename full gc attribute table states
  • 125a847: 8264788: Make SequentialSubTasksDone use-once
  • 0793fcb: 8260255: C1: LoopInvariantCodeMotion constructor can leave some fields uninitialized
  • b224b56: 8265225: jdk/jfr/tool/TestConfigure.java fails to cleanup the output files after the testing
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/e167577888b8203001b1fc516ed382bc2a96c7b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2021
@dholmes-ora
Copy link
Member Author

Thanks Erik!

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@dholmes-ora Since your change was applied there have been 15 commits pushed to the master branch:

  • b23dbdb: 8257804: Test runtime/modules/ModuleStress/ModuleStressGC.java fails: 'package test defined in module jdk.test, exports list being walked' missing from stdout/stderr
  • 9d669c9: 8262981: Create implementation for NSAccessibilitySlider protocol
  • abdff79: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails
  • b72d99e: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • 2b5869a: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS
  • bba16f6: 8264818: G1: Improve liveness check for empty pinned regions after full gc marking
  • 75da1e9: 8264423: G1: Rename full gc attribute table states
  • 125a847: 8264788: Make SequentialSubTasksDone use-once
  • 0793fcb: 8260255: C1: LoopInvariantCodeMotion constructor can leave some fields uninitialized
  • b224b56: 8265225: jdk/jfr/tool/TestConfigure.java fails to cleanup the output files after the testing
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/e167577888b8203001b1fc516ed382bc2a96c7b9...master

Your commit was automatically rebased without conflicts.

Pushed as commit 81877f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8262501 branch April 19, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants