Skip to content

8265246: Fix macos-Aarch64 build after JDK-8263709 #3506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Apr 15, 2021

Two recent macOS-Aarch64 fixes were merged into my changes without conflict, but needed editing to match my changes:

s/thread/current/

in two places.

Testing: all platform builds in mach5, including macOS-Aarch64 of course (in progress)

Thanks,
David


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265246: Fix macos-Aarch64 build after JDK-8263709

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3506/head:pull/3506
$ git checkout pull/3506

Update a local copy of the PR:
$ git checkout pull/3506
$ git pull https://git.openjdk.java.net/jdk pull/3506/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3506

View PR using the GUI difftool:
$ git pr show -t 3506

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3506.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Apr 15, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265246: Fix macos-Aarch64 build after JDK-8263709

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2021
@dholmes-ora
Copy link
Member Author

Thanks @vidmik !

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels Apr 15, 2021
@dholmes-ora dholmes-ora deleted the 8265246 branch April 15, 2021 03:02
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@dholmes-ora Pushed as commit 5931948.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants