Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails #3509

Closed
wants to merge 3 commits into from

Conversation

@jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Apr 15, 2021

This bug is filed because of pixel color mismatch and i suspect it to be related to wrong display color profile in macOS.
This test doesn't fail in local machine and in CI test machines in multiple runs.

Also this test was made to run in manual mode even though it doesnt need any User input. Modified the test to run as automated headful test and it runs fine.

I will file separate Verification task/bug to go through remaining manual tests and check whether they can be made automated headful tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3509/head:pull/3509
$ git checkout pull/3509

Update a local copy of the PR:
$ git checkout pull/3509
$ git pull https://git.openjdk.java.net/jdk pull/3509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3509

View PR using the GUI difftool:
$ git pr show -t 3509

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3509.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 15, 2021

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@jayathirthrao The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 15, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • bba16f6: 8264818: G1: Improve liveness check for empty pinned regions after full gc marking
  • 75da1e9: 8264423: G1: Rename full gc attribute table states
  • 125a847: 8264788: Make SequentialSubTasksDone use-once
  • 0793fcb: 8260255: C1: LoopInvariantCodeMotion constructor can leave some fields uninitialized

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 15, 2021
@jayathirthrao
Copy link
Member Author

@jayathirthrao jayathirthrao commented Apr 15, 2021

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added the integrated label Apr 15, 2021
@jayathirthrao jayathirthrao deleted the JDK-8163086 branch Apr 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2021

@jayathirthrao Since your change was applied there have been 6 commits pushed to the master branch:

  • b72d99e: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • 2b5869a: 8233565: [TESTBUG] NullModalityDialogTest.java fails on MacOS
  • bba16f6: 8264818: G1: Improve liveness check for empty pinned regions after full gc marking
  • 75da1e9: 8264423: G1: Rename full gc attribute table states
  • 125a847: 8264788: Make SequentialSubTasksDone use-once
  • 0793fcb: 8260255: C1: LoopInvariantCodeMotion constructor can leave some fields uninitialized

Your commit was automatically rebased without conflicts.

Pushed as commit abdff79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants