8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes #3511

walulyai · 2021-04-15T09:29:07Z

Hi all,

Please review this change to rename ConcurrentMark::liveness() to live_words() making it clear that this represents the number of live words between bottom and nTAMS. Adding ConcurrentMark::live_bytes() to return the same value in bytes. Additionally, I add a test for G1MixedGCLiveThresholdPercent flag.

Testing: tier 1-5.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes

Reviewers

Thomas Schatzl (@tschatzl - Reviewer) ⚠️ Review applies to 924f9ff
Stefan Johansson (@kstefanj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3511/head:pull/3511
$ git checkout pull/3511

Update a local copy of the PR:
$ git checkout pull/3511
$ git pull https://git.openjdk.java.net/jdk pull/3511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3511

View PR using the GUI difftool:
$ git pr show -t 3511

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3511.diff

… test for G1MixedGCLiveThresholdPercent

bridgekeeper · 2021-04-15T09:29:33Z

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-04-15T09:31:00Z

@walulyai The following label will be automatically applied to this pull request:

hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-04-15T09:34:44Z

Webrevs

01: Full - Incremental (1803f998)
00: Full (924f9ffe)

tschatzl

Lgtm apart from the few nits.

tschatzl · 2021-04-15T10:08:22Z

src/hotspot/share/gc/g1/g1ConcurrentMark.hpp

  // live words between bottom and nTAMS.
-  size_t liveness(uint region) const { return _region_mark_stats[region]._live_words; }
+  size_t live_words(uint region) const { return _region_mark_stats[region]._live_words; }
+


Something like "same as above but returns bytes" would be nice.

tschatzl · 2021-04-15T10:09:57Z

test/hotspot/jtreg/gc/g1/TestMixedGCLiveThreshold.java

+                                       "-Xms10M",
+                                       "-Xmx10M"});
+
+        basicOpts.add("-XX:G1MixedGCLiveThresholdPercent="+percent);


Whitespace before and after the +.

tschatzl · 2021-04-15T10:13:42Z

test/hotspot/jtreg/gc/g1/TestMixedGCLiveThreshold.java

+
+        Asserts.assertEquals(regionsSelected, expectedRebuild,
+                             (expectedRebuild ?
+                             "No Regions selected for rebuild. G1MixedGCLiveThresholdPercent="+ liveThresholdPercent +


Spaces before the operator at the end. There is another one below too.

openjdk · 2021-04-15T10:15:48Z

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes

Reviewed-by: tschatzl, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

c7da64a: 8265302: ProblemList runtime/logging/RedefineClasses.java on linux-x64 -Xcomp
838c11f: 8265293: ProblemList java/foreign/TestDowncall.java on macosx-aarch64
325eecb: 8255273: jshell crashes with UnsupportedOperationException: Should not get here.
e43aee5: 8262900: ToolBasicTest fails to access HTTP server it starts
c70589c: 8265227: Move Proc.java from security/testlibrary to test/lib
7b61a42: 8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test
4e90d74: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI
6293299: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
6b90715: 8265278: doc build fails after JDK-8262981
0fee6ec: 8264318: Lanai: DrawHugeImageTest.java fails on apple M1
... and 6 more: https://git.openjdk.java.net/jdk/compare/bba16f61bb52c31fead723fdc0e28e40a78ec493...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

walulyai · 2021-04-15T10:38:13Z

@tschatzl thanks for the review, I fixed the mentioned nits.

kstefanj

Looks good.

walulyai · 2021-04-15T18:12:17Z

Thanks @kstefanj

walulyai · 2021-04-16T07:28:53Z

/integrate

tschatzl

Still good.

openjdk · 2021-04-16T07:30:29Z

@walulyai Since your change was applied there have been 23 commits pushed to the master branch:

50f3da8: 8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG
e0151a6: 8264104: Eliminate unnecessary vector mask conversion during VectorUnbox for floating point VectorMask
64e2130: 8262108: SimpleDateFormat formatting broken for sq_MK Locale
3423f3e: 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods
f6e54f2: 8258794: Support for CLDR version 39
e89fd15: 8261301: StringWriter.flush() is NOOP but documentation does not indicate it
0b1b5c8: 8264373: javac hangs when annotation is declared with sealed public modifier
c7da64a: 8265302: ProblemList runtime/logging/RedefineClasses.java on linux-x64 -Xcomp
838c11f: 8265293: ProblemList java/foreign/TestDowncall.java on macosx-aarch64
325eecb: 8255273: jshell crashes with UnsupportedOperationException: Should not get here.
... and 13 more: https://git.openjdk.java.net/jdk/compare/bba16f61bb52c31fead723fdc0e28e40a78ec493...master

Your commit was automatically rebased without conflicts.

Pushed as commit fc89fe6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Rename ConcurrentMark::liveness() to live_words(), add live_bytes and…

924f9ff

… test for G1MixedGCLiveThresholdPercent

openjdk bot added the rfr Pull request is ready for review label Apr 15, 2021

openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 15, 2021

tschatzl approved these changes Apr 15, 2021

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2021

changes proposed by Thomas review

1803f99

kstefanj approved these changes Apr 15, 2021

View reviewed changes

tschatzl approved these changes Apr 16, 2021

View reviewed changes

openjdk bot closed this Apr 16, 2021

openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes #3511

8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes #3511

Uh oh!

walulyai commented Apr 15, 2021 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Apr 15, 2021

Uh oh!

openjdk bot commented Apr 15, 2021

Uh oh!

mlbridge bot commented Apr 15, 2021 •

edited

Loading

Uh oh!

tschatzl left a comment

Uh oh!

tschatzl Apr 15, 2021

Uh oh!

tschatzl Apr 15, 2021

Uh oh!

tschatzl Apr 15, 2021

Uh oh!

openjdk bot commented Apr 15, 2021 •

edited

Loading

Uh oh!

walulyai commented Apr 15, 2021

Uh oh!

kstefanj left a comment

Uh oh!

walulyai commented Apr 15, 2021

Uh oh!

walulyai commented Apr 16, 2021

Uh oh!

tschatzl left a comment

Uh oh!

openjdk bot commented Apr 16, 2021

Uh oh!

Uh oh!

8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes #3511

8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes #3511

Uh oh!

Conversation

walulyai commented Apr 15, 2021 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 15, 2021

Uh oh!

openjdk bot commented Apr 15, 2021

Uh oh!

mlbridge bot commented Apr 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

tschatzl left a comment

Choose a reason for hiding this comment

Uh oh!

tschatzl Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

tschatzl Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

tschatzl Apr 15, 2021

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Apr 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

walulyai commented Apr 15, 2021

Uh oh!

kstefanj left a comment

Choose a reason for hiding this comment

Uh oh!

walulyai commented Apr 15, 2021

Uh oh!

walulyai commented Apr 16, 2021

Uh oh!

tschatzl left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Apr 16, 2021

Uh oh!

Uh oh!

walulyai commented Apr 15, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Apr 15, 2021 •

edited

Loading

openjdk bot commented Apr 15, 2021 •

edited

Loading