8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG

[robehn]

Fixed ifdef to use correct define.

Stress tested locally, running t1-5.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3517/head:pull/3517
$ git checkout pull/3517

Update a local copy of the PR:
$ git checkout pull/3517
$ git pull https://git.openjdk.java.net/jdk pull/3517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3517

View PR using the GUI difftool:
$ git pr show -t 3517

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3517.diff

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5f92bbbf)

[chhagedorn]

Looks good.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG

Reviewed-by: chagedorn, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• 325eecb: 8255273: jshell crashes with UnsupportedOperationException: Should not get here.
• e43aee5: 8262900: ToolBasicTest fails to access HTTP server it starts
• c70589c: 8265227: Move Proc.java from security/testlibrary to test/lib
• 7b61a42: 8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test
• 4e90d74: 8048199: Replace anonymous inner classes with lambdas, where applicable, in JNDI
• 6293299: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
• 6b90715: 8265278: doc build fails after JDK-8262981
• 0fee6ec: 8264318: Lanai: DrawHugeImageTest.java fails on apple M1
• 81877f7: 8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt
• b23dbdb: 8257804: Test runtime/modules/ModuleStress/ModuleStressGC.java fails: 'package test defined in module jdk.test, exports list being walked' missing from stdout/stderr
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/b224b566491eb4d41b6ae3723fdf97b632218cfa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robehn]

Thanks!

[robehn]

Passed t1-5.

/integrate

[openjdk]

@robehn Since your change was applied there have been 26 commits pushed to the master branch:

• e0151a6: 8264104: Eliminate unnecessary vector mask conversion during VectorUnbox for floating point VectorMask
• 64e2130: 8262108: SimpleDateFormat formatting broken for sq_MK Locale
• 3423f3e: 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods
• f6e54f2: 8258794: Support for CLDR version 39
• e89fd15: 8261301: StringWriter.flush() is NOOP but documentation does not indicate it
• 0b1b5c8: 8264373: javac hangs when annotation is declared with sealed public modifier
• c7da64a: 8265302: ProblemList runtime/logging/RedefineClasses.java on linux-x64 -Xcomp
• 838c11f: 8265293: ProblemList java/foreign/TestDowncall.java on macosx-aarch64
• 325eecb: 8255273: jshell crashes with UnsupportedOperationException: Should not get here.
• e43aee5: 8262900: ToolBasicTest fails to access HTTP server it starts
• ... and 16 more: https://git.openjdk.java.net/jdk/compare/b224b566491eb4d41b6ae3723fdf97b632218cfa...master

Your commit was automatically rebased without conflicts.

Pushed as commit 50f3da8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.