Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265278: doc build fails after JDK-8262981 #3518

Closed
wants to merge 1 commit into from

Conversation

pankaj-bansal
Copy link

@pankaj-bansal pankaj-bansal commented Apr 15, 2021

The doc build fails after the JDK-8262981. The JDK-8262981 adds a new function, but by mistake the param name used in function is different from the param name mentioned in @param tag. This breaks the doc build.

This change corrects the param name. I have verified that the doc build runs successfully after the changes by running following command. It fails before the current change and passes with the change.

"make jdk-image docs-jdk"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3518/head:pull/3518
$ git checkout pull/3518

Update a local copy of the PR:
$ git checkout pull/3518
$ git pull https://git.openjdk.java.net/jdk pull/3518/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3518

View PR using the GUI difftool:
$ git pr show -t 3518

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3518.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2021

👋 Welcome back pbansal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@pankaj-bansal The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Apr 15, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@pankaj-bansal This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265278: doc build fails after JDK-8262981

Reviewed-by: jdv, trebari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0fee6ec: 8264318: Lanai: DrawHugeImageTest.java fails on apple M1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2021
@pankaj-bansal
Copy link
Author

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@pankaj-bansal Since your change was applied there has been 1 commit pushed to the master branch:

  • 0fee6ec: 8264318: Lanai: DrawHugeImageTest.java fails on apple M1

Your commit was automatically rebased without conflicts.

Pushed as commit 6b90715.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pankaj-bansal pankaj-bansal deleted the JDK-8265278 branch April 15, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
3 participants