New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265278: doc build fails after JDK-8262981 #3518
Conversation
|
@pankaj-bansal The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@pankaj-bansal This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
/integrate |
@pankaj-bansal Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6b90715. |
The doc build fails after the JDK-8262981. The JDK-8262981 adds a new function, but by mistake the param name used in function is different from the param name mentioned in @param tag. This breaks the doc build.
This change corrects the param name. I have verified that the doc build runs successfully after the changes by running following command. It fails before the current change and passes with the change.
"make jdk-image docs-jdk"
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3518/head:pull/3518
$ git checkout pull/3518
Update a local copy of the PR:
$ git checkout pull/3518
$ git pull https://git.openjdk.java.net/jdk pull/3518/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3518
View PR using the GUI difftool:
$ git pr show -t 3518
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3518.diff