Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265293: ProblemList java/foreign/TestDowncall.java on macosx-aarch64 #3520

Closed
wants to merge 1 commit into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Apr 15, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265293: ProblemList java/foreign/TestDowncall.java on macosx-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3520/head:pull/3520
$ git checkout pull/3520

Update a local copy of the PR:
$ git checkout pull/3520
$ git pull https://git.openjdk.java.net/jdk pull/3520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3520

View PR using the GUI difftool:
$ git pr show -t 3520

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3520.diff

@vidmik
Copy link
Contributor Author

vidmik commented Apr 15, 2021

/label hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 15, 2021

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@vidmik
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 15, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 15, 2021

Webrevs

Copy link
Member

@calvinccheung calvinccheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265293: ProblemList java/foreign/TestDowncall.java on macosx-aarch64

Reviewed-by: ccheung, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e43aee5: 8262900: ToolBasicTest fails to access HTTP server it starts
  • c70589c: 8265227: Move Proc.java from security/testlibrary to test/lib

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 15, 2021
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix and does not need to wait 24 hours.

@vidmik
Copy link
Contributor Author

vidmik commented Apr 15, 2021

/integrate

@openjdk openjdk bot closed this Apr 15, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 15, 2021
@openjdk
Copy link

openjdk bot commented Apr 15, 2021

@vidmik Since your change was applied there have been 3 commits pushed to the master branch:

  • 325eecb: 8255273: jshell crashes with UnsupportedOperationException: Should not get here.
  • e43aee5: 8262900: ToolBasicTest fails to access HTTP server it starts
  • c70589c: 8265227: Move Proc.java from security/testlibrary to test/lib

Your commit was automatically rebased without conflicts.

Pushed as commit 838c11f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vidmik vidmik deleted the 8265293-plist-8265292 branch April 29, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants