8265313: Obsolete the unused AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags

[dholmes-ora]

The AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags became unused with the changes in JDK-8223312 and should have been obsoleted then.

Thanks,
David

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265313: Obsolete the unused AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Harold Seigel (@hseigel - Reviewer)
• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3527/head:pull/3527
$ git checkout pull/3527

Update a local copy of the PR:
$ git checkout pull/3527
$ git pull https://git.openjdk.java.net/jdk pull/3527/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3527

View PR using the GUI difftool:
$ git pr show -t 3527

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3527.diff

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[dholmes-ora]

/csr needed

[openjdk]

@dholmes-ora has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@dholmes-ora please create a CSR request and add link to it in JDK-8265314. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (abf0815c)

[shipilev]

This looks fine. But I think this PR mistakenly references the CSR itself, rather than the implementation (JDK-8265313), which is why bots complain.

[dholmes-ora]

/issue remove JDK-8265314
/issue add JDK-8265313

[mlbridge]

Mailing list message from David Holmes on hotspot-runtime-dev:

On 16/04/2021 5:50 pm, Aleksey Shipilev wrote:

On Fri, 16 Apr 2021 01:35:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

The AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags became unused with the changes in JDK-8223312 and should have been obsoleted then.

Thanks,
David

This looks fine. But I think this PR mistakenly references the CSR itself, rather than the implementation (JDK-8265313), which is why bots complain.

Doh! Thanks Aleksey - yes I messed up. Will try to fix.

David

[mlbridge]

Mailing list message from David Holmes on hotspot-runtime-dev:

On 16/04/2021 5:50 pm, Aleksey Shipilev wrote:

On Fri, 16 Apr 2021 01:35:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

The AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags became unused with the changes in JDK-8223312 and should have been obsoleted then.

Thanks,
David

This looks fine. But I think this PR mistakenly references the CSR itself, rather than the implementation (JDK-8265313), which is why bots complain.

Doh! Thanks Aleksey - yes I messed up. Will try to fix.

David

[openjdk]

@dholmes-ora This PR does not contain any additional solved issues that can be removed. To remove the primary solved issue, simply edit the title of this PR.

[openjdk]

@dholmes-ora This issue is referenced in the PR title - it will now be updated.

[hseigel]

Looks good and trivial.

Harold

[dholmes-ora]

Thanks Harold! I have to wait for the CSR to be approved before integrating anyway.

[dcubed-ojdk]

Thumbs up!

[mlbridge]

Mailing list message from David Holmes on hotspot-runtime-dev:

On 17/04/2021 12:56 am, Daniel D.Daugherty wrote:

On Fri, 16 Apr 2021 01:35:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

The AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags became unused with the changes in JDK-8223312 and should have been obsoleted then.

Thanks,
David

Thumbs up!

Thanks for the review here and of the CSR request Dan!

David

[mlbridge]

Mailing list message from David Holmes on hotspot-runtime-dev:

On 17/04/2021 12:56 am, Daniel D.Daugherty wrote:

On Fri, 16 Apr 2021 01:35:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

The AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags became unused with the changes in JDK-8223312 and should have been obsoleted then.

Thanks,
David

Thumbs up!

Thanks for the review here and of the CSR request Dan!

David

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265313: Obsolete the unused AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags

Reviewed-by: shade, hseigel, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• cb8394a: 8265304: Temporarily make Metal the default 2D rendering pipeline for macOS
• 66f8987: 8265298: Hard VM crash when deadlock between "access" and higher ranked lock is detected
• 926e3bc: 8264143: Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1
• ff49970: 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter
• c108e7a: 8265154: vinserti128 operand mix up for KNL platforms
• 2c4075c: 8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp
• 888d80b: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
• 0bdc3e7: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits
• 4413dbf: 8263395: Incorrect use of Objects.nonNull
• 74d03ab: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/3423f3e1f5a2120e8f761a238c2929c44957760d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

/integrate

[openjdk]

@dholmes-ora Since your change was applied there have been 27 commits pushed to the master branch:

• cb8394a: 8265304: Temporarily make Metal the default 2D rendering pipeline for macOS
• 66f8987: 8265298: Hard VM crash when deadlock between "access" and higher ranked lock is detected
• 926e3bc: 8264143: Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1
• ff49970: 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter
• c108e7a: 8265154: vinserti128 operand mix up for KNL platforms
• 2c4075c: 8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp
• 888d80b: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
• 0bdc3e7: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits
• 4413dbf: 8263395: Incorrect use of Objects.nonNull
• 74d03ab: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.
• ... and 17 more: https://git.openjdk.java.net/jdk/compare/3423f3e1f5a2120e8f761a238c2929c44957760d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 73d5f3b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.