Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253631: Remove unimplemented CompileBroker methods after JEP-165 #353

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 25, 2020

It would seem that JEP-175 implementation task (JDK-8137167) introduced declarations without any implementations in CompilerBroker:

  static DirectivesStack* dirstack();
  static void set_dirstack(DirectivesStack* stack);
  static void print_directives(outputStream* st);

This can be cleaned up.

Testing:

  • Linux x86_64 fastdebug build
  • Text searches for dirstack and print_directives in src/hotspot

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253631: Remove unimplemented CompileBroker methods after JEP-165

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/353/head:pull/353
$ git checkout pull/353

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 25, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@shipilev The following label will be automatically applied to this pull request: hotspot-compiler.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 25, 2020

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good and trivial.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

8253631: Remove unimplemented CompileBroker methods after JEP-165

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • e12d94a: 8253594: Remove CollectedHeap::supports_tlab_allocation
  • cfa3f74: 8245527: LDAP Channel Binding support for Java GSS/Kerberos
  • 37b7028: 8240556: Abort concurrent mark after effective eager reclamation of humongous objects
  • dcde95b: 8253586: C2: Clean up unused PhaseIterGVN::init_worklist()
  • 0b83fc0: 8235710: Remove the legacy elliptic curves
  • 8239b67: 8253322: Update the specification in the newly added constructors
  • 24a4248: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle
  • 8b85c3a: 8251261: CDS dumping should not clear states in live classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 25, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 25, 2020

/integrate

@openjdk openjdk bot closed this Sep 25, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 25, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 25, 2020

@shipilev Since your change was applied there have been 9 commits pushed to the master branch:

  • 27d0a70: 8253633: Remove unimplemented TieredThresholdPolicy::set_carry_if_neccessary
  • e12d94a: 8253594: Remove CollectedHeap::supports_tlab_allocation
  • cfa3f74: 8245527: LDAP Channel Binding support for Java GSS/Kerberos
  • 37b7028: 8240556: Abort concurrent mark after effective eager reclamation of humongous objects
  • dcde95b: 8253586: C2: Clean up unused PhaseIterGVN::init_worklist()
  • 0b83fc0: 8235710: Remove the legacy elliptic curves
  • 8239b67: 8253322: Update the specification in the newly added constructors
  • 24a4248: 8253615: Change to Visual Studio 2019 16.7.2 for building on Windows at Oracle
  • 8b85c3a: 8251261: CDS dumping should not clear states in live classes

Your commit was automatically rebased without conflicts.

Pushed as commit dc1ef58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the shipilev:JDK-8253631-unimpl-compilerbroker branch Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants