Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265245: depChecker_<cpu> don't have any functionalities #3531

Closed
wants to merge 1 commit into from

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Apr 16, 2021

Yet another OpenJDK6 old guy.

src/hotspot/cpu//depChecker_.hpp/cpp are included by src/hotspot/share/compiler/disassembler.cpp, they don't provide any functionality.

In the absence of strong demand either in existing ARCHs or future ARCHs, I think we can remove it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265245: depChecker_ don't have any functionalities

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3531/head:pull/3531
$ git checkout pull/3531

Update a local copy of the PR:
$ git checkout pull/3531
$ git pull https://git.openjdk.java.net/jdk pull/3531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3531

View PR using the GUI difftool:
$ git pr show -t 3531

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3531.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 16, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@kelthuzadx The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 16, 2021

Webrevs

Loading

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks good to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265245: depChecker_<cpu> don't have any functionalities

Reviewed-by: thartmann, neliasso

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 112 new commits pushed to the master branch:

  • 1ac25b8: 8264372: Threads::destroy_vm only ever returns true
  • 73d5f3b: 8265313: Obsolete the unused AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags
  • cb8394a: 8265304: Temporarily make Metal the default 2D rendering pipeline for macOS
  • 66f8987: 8265298: Hard VM crash when deadlock between "access" and higher ranked lock is detected
  • 926e3bc: 8264143: Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1
  • ff49970: 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter
  • c108e7a: 8265154: vinserti128 operand mix up for KNL platforms
  • 2c4075c: 8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp
  • 888d80b: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
  • 0bdc3e7: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits
  • ... and 102 more: https://git.openjdk.java.net/jdk/compare/ecef1fc82b71addff4345f98f53946525c000067...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @neliasso) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Apr 16, 2021
Copy link
Contributor

@neliasso neliasso left a comment

Nice cleanup.

Approved.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 19, 2021

Thanks @TobiHartmann and @neliasso for the reviews.

/integrate

Loading

@openjdk openjdk bot added the sponsor label Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@kelthuzadx
Your change (at version 9d6ce4c) is now ready to be sponsored by a Committer.

Loading

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 19, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@TobiHartmann @kelthuzadx Since your change was applied there have been 113 commits pushed to the master branch:

  • a2b0e0f: 8265323: Leftover local variables in PcDesc
  • 1ac25b8: 8264372: Threads::destroy_vm only ever returns true
  • 73d5f3b: 8265313: Obsolete the unused AssertOnSuspendWaitFailure and TraceSuspendWaitFailures flags
  • cb8394a: 8265304: Temporarily make Metal the default 2D rendering pipeline for macOS
  • 66f8987: 8265298: Hard VM crash when deadlock between "access" and higher ranked lock is detected
  • 926e3bc: 8264143: Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1
  • ff49970: 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter
  • c108e7a: 8265154: vinserti128 operand mix up for KNL platforms
  • 2c4075c: 8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp
  • 888d80b: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
  • ... and 103 more: https://git.openjdk.java.net/jdk/compare/ecef1fc82b71addff4345f98f53946525c000067...master

Your commit was automatically rebased without conflicts.

Pushed as commit fa58aae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kelthuzadx kelthuzadx deleted the remove_depchecker branch Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants