-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8265304: Temporarily make Metal the default 2D rendering pipeline for macOS #3534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into |
|
/csr |
|
@aghaisas this pull request will not be integrated until the CSR request JDK-8265305 for issue JDK-8265304 has been approved. |
jayathirthrao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please make sure CI test run is fine before integration.
|
@aghaisas This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
@aghaisas Since your change was applied there have been 26 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit cb8394a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR makes Metal as the default Java2D rendering pipeline for macOS.
Note : from JBS description :
The plan of record has always been that for JDK 17 the new Metal pipeline will be OFF by default and must be explicitly enabled by setting a system property.
We are not changing that plan but to get more testing exposure we intend to make it the default (instead of OpenGL) for approximately one month (from the next build up to the 20th May build of JDK 17).
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3534/head:pull/3534$ git checkout pull/3534Update a local copy of the PR:
$ git checkout pull/3534$ git pull https://git.openjdk.java.net/jdk pull/3534/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3534View PR using the GUI difftool:
$ git pr show -t 3534Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3534.diff