Skip to content

Conversation

@aghaisas
Copy link
Contributor

@aghaisas aghaisas commented Apr 16, 2021

This PR makes Metal as the default Java2D rendering pipeline for macOS.

Note : from JBS description :
The plan of record has always been that for JDK 17 the new Metal pipeline will be OFF by default and must be explicitly enabled by setting a system property.
We are not changing that plan but to get more testing exposure we intend to make it the default (instead of OpenGL) for approximately one month (from the next build up to the 20th May build of JDK 17).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265304: Temporarily make Metal the default 2D rendering pipeline for macOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3534/head:pull/3534
$ git checkout pull/3534

Update a local copy of the PR:
$ git checkout pull/3534
$ git pull https://git.openjdk.java.net/jdk pull/3534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3534

View PR using the GUI difftool:
$ git pr show -t 3534

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3534.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2021

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@aghaisas The following label will be automatically applied to this pull request:

  • 2d

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the 2d client-libs-dev@openjdk.org label Apr 16, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2021

Webrevs

@aghaisas
Copy link
Contributor Author

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@aghaisas this pull request will not be integrated until the CSR request JDK-8265305 for issue JDK-8265304 has been approved.

Copy link
Member

@jayathirthrao jayathirthrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure CI test run is fine before integration.

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@aghaisas This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265304: Temporarily make Metal the default 2D rendering pipeline for macOS

Reviewed-by: jdv, kcr, azvegint, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 7c37c02: 8244190: JFR: When starting a JVM with -XX:StartFlightRecording, output is written to stdout
  • 79adc16: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 1c3fd46: 8265175: (fs) Files.copy(Path,Path,CopyOption...) should use sendfile on Linux
  • cee4f1d: 8203925: tools/javac/importscope/T8193717.java ran out of java heap
  • 694e1cd: 8262060: compiler/whitebox/BlockingCompilation.java timed out
  • 6946d91: 8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF
  • 714298a: 8265259: G1: Fix HeapRegion::block_is_obj for unloading class in full gc
  • ff5bb8c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
  • 17b6592: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
  • 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
  • ... and 7 more: https://git.openjdk.java.net/jdk/compare/3423f3e1f5a2120e8f761a238c2929c44957760d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2021
@aghaisas
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Apr 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2021
@openjdk
Copy link

openjdk bot commented Apr 17, 2021

@aghaisas Since your change was applied there have been 26 commits pushed to the master branch:

  • 66f8987: 8265298: Hard VM crash when deadlock between "access" and higher ranked lock is detected
  • 926e3bc: 8264143: Lanai: RenderPerfTest.BgrSwBlitImage has artefacts on apple M1
  • ff49970: 8265375: Bootcycle builds fail with StackOverflowError in cldrconverter
  • c108e7a: 8265154: vinserti128 operand mix up for KNL platforms
  • 2c4075c: 8265381: ProblemList runtime/logging/RedefineClasses.java on macos-x64 -Xcomp
  • 888d80b: 8265358: ProblemList jdk/jshell/ToolBasicTest.java on macOS-aarch64
  • 0bdc3e7: 8262744: Formatter '%g' conversion uses wrong format for BigDecimal rounding up to limits
  • 4413dbf: 8263395: Incorrect use of Objects.nonNull
  • 74d03ab: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.
  • 7c37c02: 8244190: JFR: When starting a JVM with -XX:StartFlightRecording, output is written to stdout
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/3423f3e1f5a2120e8f761a238c2929c44957760d...master

Your commit was automatically rebased without conflicts.

Pushed as commit cb8394a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2d client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants