Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described. #3541

Closed
wants to merge 1 commit into from

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Apr 16, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3541/head:pull/3541
$ git checkout pull/3541

Update a local copy of the PR:
$ git checkout pull/3541
$ git pull https://git.openjdk.java.net/jdk pull/3541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3541

View PR using the GUI difftool:
$ git pr show -t 3541

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3541.diff

…en pressed the button, the background color can not be changed in accordance with the case described.

Moved from closed tests.
Changed look and feel to WindowsClassicLookAndFeel.
Cleaned up imports.
Added main method so it is easier to debug on the local machine.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 16, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 16, 2021

Webrevs

Loading

@trebari
Copy link
Member

@trebari trebari commented Apr 16, 2021

Should we also remove the deprecated JApplet from the test ?

Loading

@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Apr 16, 2021

Should we also remove the deprecated JApplet from the test ?

Once we decide how to properly deal with all the applet-based tests they will be converted into application-type tests but for now it is outside of the scope of this fix.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8039270: The background color of  the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.

Reviewed-by: azvegint, trebari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 6946d91: 8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF
  • 714298a: 8265259: G1: Fix HeapRegion::block_is_obj for unloading class in full gc
  • ff5bb8c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
  • 17b6592: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
  • 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
  • 7137328: 8264958: C2 compilation fails with assert "n is later than its clone"
  • 1d66a15: 8265330: G1: Fix comment in G1FullGCPrepareTask::G1CalculatePointersClosure
  • b4ba74e: 8264987: G1: Fill BOTs for Survivor-turned-to-Old regions in full gc
  • fc89fe6: 8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes
  • 50f3da8: 8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/bba16f61bb52c31fead723fdc0e28e40a78ec493...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 16, 2021
@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Apr 16, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@azuev-java Since your change was applied there have been 37 commits pushed to the master branch:

  • 7c37c02: 8244190: JFR: When starting a JVM with -XX:StartFlightRecording, output is written to stdout
  • 79adc16: 8264152: javax/net/ssl/DTLS/RespondToRetransmit.java timed out
  • 1c3fd46: 8265175: (fs) Files.copy(Path,Path,CopyOption...) should use sendfile on Linux
  • cee4f1d: 8203925: tools/javac/importscope/T8193717.java ran out of java heap
  • 694e1cd: 8262060: compiler/whitebox/BlockingCompilation.java timed out
  • 6946d91: 8075915: The eight controls without black backgrounds with WinLAF & GTK LAF & Nimbus LAF
  • 714298a: 8265259: G1: Fix HeapRegion::block_is_obj for unloading class in full gc
  • ff5bb8c: 8265239: Shenandoah: Shenandoah heap region count could be off by 1
  • 17b6592: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
  • 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/bba16f61bb52c31fead723fdc0e28e40a78ec493...master

Your commit was automatically rebased without conflicts.

Pushed as commit 74d03ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@azuev-java azuev-java deleted the JDK-8039270 branch Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants