Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description #3543

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Apr 16, 2021

Trivial: should be "shrink", not "shrik".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3543/head:pull/3543
$ git checkout pull/3543

Update a local copy of the PR:
$ git checkout pull/3543
$ git pull https://git.openjdk.java.net/jdk pull/3543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3543

View PR using the GUI difftool:
$ git pr show -t 3543

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3543.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Apr 16, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2021

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and trivial.

@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

  • 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
  • 7137328: 8264958: C2 compilation fails with assert "n is later than its clone"
  • 1d66a15: 8265330: G1: Fix comment in G1FullGCPrepareTask::G1CalculatePointersClosure
  • b4ba74e: 8264987: G1: Fill BOTs for Survivor-turned-to-Old regions in full gc
  • fc89fe6: 8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes
  • 50f3da8: 8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG
  • e0151a6: 8264104: Eliminate unnecessary vector mask conversion during VectorUnbox for floating point VectorMask
  • 64e2130: 8262108: SimpleDateFormat formatting broken for sq_MK Locale
  • 3423f3e: 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods
  • f6e54f2: 8258794: Support for CLDR version 39
  • ... and 75 more: https://git.openjdk.java.net/jdk/compare/125184e96f577bbc031c3eba40b185b2b728b2c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2021
@shipilev
Copy link
Member Author

Thanks!

/integrate

@openjdk openjdk bot closed this Apr 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@shipilev Since your change was applied there have been 85 commits pushed to the master branch:

  • 10ec38f: 8262462: IGV: cannot remove specific groups imported via network
  • 7137328: 8264958: C2 compilation fails with assert "n is later than its clone"
  • 1d66a15: 8265330: G1: Fix comment in G1FullGCPrepareTask::G1CalculatePointersClosure
  • b4ba74e: 8264987: G1: Fill BOTs for Survivor-turned-to-Old regions in full gc
  • fc89fe6: 8265119: G1: update_remset_before_rebuild mixes liveness in words with liveness in bytes
  • 50f3da8: 8264480: Unreachable code in nmethod.cpp inside #ifdef DEBUG
  • e0151a6: 8264104: Eliminate unnecessary vector mask conversion during VectorUnbox for floating point VectorMask
  • 64e2130: 8262108: SimpleDateFormat formatting broken for sq_MK Locale
  • 3423f3e: 8265180: JvmtiCompiledMethodLoadEvent should include the stub section of nmethods
  • f6e54f2: 8258794: Support for CLDR version 39
  • ... and 75 more: https://git.openjdk.java.net/jdk/compare/125184e96f577bbc031c3eba40b185b2b728b2c7...master

Your commit was automatically rebased without conflicts.

Pushed as commit 17b6592.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8265335-epsilon-typo branch May 11, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants