Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle #3550

Closed
wants to merge 1 commit into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 16, 2021

Oracle is updating the minor version of Visual Studio for building the JDK to 16.9.3.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3550/head:pull/3550
$ git checkout pull/3550

Update a local copy of the PR:
$ git checkout pull/3550
$ git pull https://git.openjdk.java.net/jdk pull/3550/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3550

View PR using the GUI difftool:
$ git pr show -t 3550

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3550.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 16, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Apr 16, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 16, 2021

Webrevs

vidmik
vidmik approved these changes Apr 16, 2021
@openjdk
Copy link

openjdk bot commented Apr 16, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 74d03ab: 8039270: The background color of the button can't be displayed and when pressed the button, the background color can not be changed in accordance with the case described.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 16, 2021
@erikj79
Copy link
Member Author

erikj79 commented Apr 19, 2021

/integrate

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 19, 2021
@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@erikj79 Since your change was applied there have been 22 commits pushed to the master branch:

  • c887148: 8265079: Implement VarHandle invoker caching
  • b64a3fb: 8265325: Optimize StubRoutines::dpow() for Math.pow(x, 0.5)
  • d1c8c9e: 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows
  • 7d01c98: 8265414: Variable assigned but not used in G1FreeHumongousRegionClosure
  • d9e19f1: 8265226: (dc) API note in DatagramChannel.open should link to StandardProtocolFamily.UNIX
  • 49b9e68: 8262165: NMT report should state how many callsites had been skipped
  • e390e55: 8265066: Split ReservedSpace constructor to avoid default parameter
  • c607d12: 8249528: Remove obsolete comment in G1RootProcessor::process_java_roots
  • fa58aae: 8265245: depChecker_ don't have any functionalities
  • a2b0e0f: 8265323: Leftover local variables in PcDesc
  • ... and 12 more: https://git.openjdk.java.net/jdk/compare/7c37c022a1664437bf8d2c8d76ad039521f3ffa7...master

Your commit was automatically rebased without conflicts.

Pushed as commit b14e0ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
2 participants