Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8265373: Change to GCC 10.3 for building on Linux at Oracle #3551

Closed
wants to merge 7 commits into from

Conversation

erikj79
Copy link
Member

@erikj79 erikj79 commented Apr 16, 2021

Oracle is updating the version of GCC for building the JDK to 10.3.

In addition to the version bump, I'm also enabling cross compilation OOTB using jib from a linux-aarch64 to linux-x64 binaries, which was the last missing combination. (Native x64, native aarch64, cross from x64 to aarch64 all worked already and will continue to do so.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265373: Change to GCC 10.3 for building on Linux at Oracle

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3551/head:pull/3551
$ git checkout pull/3551

Update a local copy of the PR:
$ git checkout pull/3551
$ git pull https://git.openjdk.java.net/jdk pull/3551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3551

View PR using the GUI difftool:
$ git pr show -t 3551

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3551.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 16, 2021

👋 Welcome back erikj! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@erikj79 The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Apr 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 16, 2021

Webrevs

make/conf/jib-profiles.js Outdated Show resolved Hide resolved
vidmik
vidmik approved these changes Apr 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2021

@erikj79 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265373: Change to GCC 10.3 for building on Linux at Oracle

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 16, 2021
@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Apr 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@erikj79 Since your change was applied there have been 32 commits pushed to the master branch:

  • 3990713: 8265463: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp
  • 5b43b39: 8263154: [macos] DMG builds have finder errors
  • 54cb388: 8252600: [JVMCI] remove mx configuration
  • b703e0a: 8264569: Remove obsolete error messages from CDSTestUtils.java
  • 235daea: 8265285: Unnecessary inclusion of bytecodeHistogram.hpp
  • 8bec6fe: 8264277: java.xml.crypto module should be granted FilePermission and SocketPermission
  • 5303ccb: 8265135: Reduce work initializing VarForms
  • d9e40dd: 8199407: Skip Rebuild Remset Phase if there are no rebuild candidates
  • 8dbf7aa: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params
  • b14e0ee: 8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle
  • ... and 22 more: https://git.openjdk.java.net/jdk/compare/7c37c022a1664437bf8d2c8d76ad039521f3ffa7...master

It was not possible to rebase your changes automatically. Please merge master into your branch and try again.

@erikj79
Copy link
Member Author

@erikj79 erikj79 commented Apr 19, 2021

/integrate

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@erikj79 Pushed as commit 713483c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
2 participants