Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257459: Bump minimum boot jdk to JDK 16 #3555

Closed
wants to merge 2 commits into from

Conversation

vidmik
Copy link
Contributor

@vidmik vidmik commented Apr 17, 2021

With JDK 16 having gone GA about a month ago it's time to bump the minimum boot JDK version for mainline/JDK 17.

Testing: tier1-5.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3555/head:pull/3555
$ git checkout pull/3555

Update a local copy of the PR:
$ git checkout pull/3555
$ git pull https://git.openjdk.java.net/jdk pull/3555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3555

View PR using the GUI difftool:
$ git pr show -t 3555

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3555.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 17, 2021

👋 Welcome back mikael! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 17, 2021
@openjdk
Copy link

openjdk bot commented Apr 17, 2021

@vidmik The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build label Apr 17, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 17, 2021

@vidmik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257459: Bump minimum boot jdk to JDK 16

Reviewed-by: darcy, iris, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • c887148: 8265079: Implement VarHandle invoker caching
  • b64a3fb: 8265325: Optimize StubRoutines::dpow() for Math.pow(x, 0.5)
  • d1c8c9e: 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows
  • 7d01c98: 8265414: Variable assigned but not used in G1FreeHumongousRegionClosure
  • d9e19f1: 8265226: (dc) API note in DatagramChannel.open should link to StandardProtocolFamily.UNIX
  • 49b9e68: 8262165: NMT report should state how many callsites had been skipped
  • e390e55: 8265066: Split ReservedSpace constructor to avoid default parameter
  • c607d12: 8249528: Remove obsolete comment in G1RootProcessor::process_java_roots
  • fa58aae: 8265245: depChecker_ don't have any functionalities
  • a2b0e0f: 8265323: Leftover local variables in PcDesc
  • ... and 29 more: https://git.openjdk.java.net/jdk/compare/3423f3e1f5a2120e8f761a238c2929c44957760d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 17, 2021
@vidmik
Copy link
Contributor Author

vidmik commented Apr 20, 2021

Joe, Iris, Erik - thank you for the reviews!

/integrate

@openjdk openjdk bot closed this Apr 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@vidmik Since your change was applied there have been 61 commits pushed to the master branch:

  • c52e5f2: 8265435: Remove dummy lists in G1CalculatePointersClosure
  • 072ae7e: 8265436: G1: Improve gc+phases log output during full gc
  • d81b046: 8263227: C2: inconsistent spilling due to dead nodes in exception block
  • a25bae8: 8261445: Use memory_order_relaxed for os::random().
  • 5136643: 8262725: IGV: crash when removing all graphs in a group
  • 79798c6: 8265136: ZGC: Expose GarbageCollectorMXBeans for both pauses and cycles
  • f1d4ae6: 8263718: unused-result warning happens at os_linux.cpp
  • 787908c: 8264221: Rewrite confusing stream API chain in SnippetMaps
  • 142edd3: 8265152: jpackage cleanup fails on Windows with IOException deleting msi
  • ab22407: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64
  • ... and 51 more: https://git.openjdk.java.net/jdk/compare/3423f3e1f5a2120e8f761a238c2929c44957760d...master

Your commit was automatically rebased without conflicts.

Pushed as commit 72c88fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vidmik vidmik deleted the 8257459-bootjdk16 branch Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build integrated
4 participants