Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252600: [JVMCI] remove mx configuration #3559

Closed
wants to merge 1 commit into from
Closed

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Apr 17, 2021

This PR removes the mx configuration files in the JDK as they do not really belong here. Instead, I've updated and moved them to https://github.com/dougxc/mx_jdk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3559/head:pull/3559
$ git checkout pull/3559

Update a local copy of the PR:
$ git checkout pull/3559
$ git pull https://git.openjdk.java.net/jdk pull/3559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3559

View PR using the GUI difftool:
$ git pr show -t 3559

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3559.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 17, 2021

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2021

@dougxc The following labels will be automatically applied to this pull request:

  • build
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@dougxc dougxc marked this pull request as ready for review Apr 17, 2021
@openjdk openjdk bot added the rfr label Apr 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 17, 2021

Webrevs

Loading

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Apr 18, 2021

Are you sure it make sense to have this dev config in the openjdk/jdk repo? I would think this is something for the downstream Graal repos.

Loading

@dougxc
Copy link
Member Author

@dougxc dougxc commented Apr 18, 2021

Until we have downstream repos for JDK 17, it's very handy to have this config in the JDK. I've tried to keep it only in JVMCI related directories so as to not perturb non-JVMCI sources. However, if the consensus is that this config does not belong in the JDK at all, I will repurpose this PR to remove all such config as it's current broken as is.

Loading

@dougxc dougxc changed the title 8252600: [JVMCI] update JVMCI code style and mx configuration 8252600: remove mx configuration Apr 18, 2021
@dougxc
Copy link
Member Author

@dougxc dougxc commented Apr 18, 2021

On second thoughts, I concur with you Alan and am thus using this PR to remove the mx configuration files.

Loading

Copy link
Contributor

@vnkozlov vnkozlov left a comment

The PR is missing [JVMCI] in title to match RFE title. Otherwise it is good.

Loading

@dougxc dougxc changed the title 8252600: remove mx configuration 8252600: [JVMCI] remove mx configuration Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8252600: [JVMCI] remove mx configuration

Reviewed-by: erikj, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • b703e0a: 8264569: Remove obsolete error messages from CDSTestUtils.java
  • 235daea: 8265285: Unnecessary inclusion of bytecodeHistogram.hpp
  • 8bec6fe: 8264277: java.xml.crypto module should be granted FilePermission and SocketPermission
  • 5303ccb: 8265135: Reduce work initializing VarForms
  • d9e40dd: 8199407: Skip Rebuild Remset Phase if there are no rebuild candidates
  • 8dbf7aa: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params
  • b14e0ee: 8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle
  • c887148: 8265079: Implement VarHandle invoker caching
  • b64a3fb: 8265325: Optimize StubRoutines::dpow() for Math.pow(x, 0.5)
  • d1c8c9e: 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/cb8394a841023b2cf4a9103f47f50e3fd28c5b04...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 19, 2021
@dougxc
Copy link
Member Author

@dougxc dougxc commented Apr 19, 2021

Thanks @AlanBateman , @erikj79 and @vnkozlov for the reviews.

Loading

@dougxc
Copy link
Member Author

@dougxc dougxc commented Apr 19, 2021

/integrate

Loading

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dougxc Since your change was applied there have been 19 commits pushed to the master branch:

  • b703e0a: 8264569: Remove obsolete error messages from CDSTestUtils.java
  • 235daea: 8265285: Unnecessary inclusion of bytecodeHistogram.hpp
  • 8bec6fe: 8264277: java.xml.crypto module should be granted FilePermission and SocketPermission
  • 5303ccb: 8265135: Reduce work initializing VarForms
  • d9e40dd: 8199407: Skip Rebuild Remset Phase if there are no rebuild candidates
  • 8dbf7aa: 8241306: Add SignatureMethodParameterSpec subclass for RSASSA-PSS params
  • b14e0ee: 8265371: Change to Visual Studio 2019 16.9.3 for building on Windows at Oracle
  • c887148: 8265079: Implement VarHandle invoker caching
  • b64a3fb: 8265325: Optimize StubRoutines::dpow() for Math.pow(x, 0.5)
  • d1c8c9e: 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows
  • ... and 9 more: https://git.openjdk.java.net/jdk/compare/cb8394a841023b2cf4a9103f47f50e3fd28c5b04...master

Your commit was automatically rebased without conflicts.

Pushed as commit 54cb388.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dougxc dougxc deleted the JDK-8252600 branch May 2, 2021
@dougxc dougxc restored the JDK-8252600 branch May 2, 2021
@dougxc dougxc deleted the JDK-8252600 branch May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants