Skip to content

8265407: JFR: Fix Typos #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8265407: JFR: Fix Typos #3562

wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Apr 18, 2021

Hi,

Could I have a review of a fix that takes care of couple of typos.

Testing: test/jdk/jdk/jfr/

Thanks
Erik


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3562/head:pull/3562
$ git checkout pull/3562

Update a local copy of the PR:
$ git checkout pull/3562
$ git pull https://git.openjdk.java.net/jdk pull/3562/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3562

View PR using the GUI difftool:
$ git pr show -t 3562

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3562.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2021

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2021

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Apr 18, 2021
@egahlin egahlin changed the title JFR: Fix Typos 8265407: JFR: Fix Typos Apr 18, 2021
@egahlin egahlin marked this pull request as ready for review April 18, 2021 22:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 19, 2021
@mlbridge
Copy link

mlbridge bot commented Apr 19, 2021

Webrevs

Copy link

@mgronlun mgronlun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -83,7 +82,7 @@
* rs.onEvent("jdk.GCPhasePause", System.out::println);
* rs.start();
* }
* }
* }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want it to align with the starting brace.

@openjdk
Copy link

openjdk bot commented Apr 19, 2021

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265407: JFR: Fix Typos

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • e390e55: 8265066: Split ReservedSpace constructor to avoid default parameter
  • c607d12: 8249528: Remove obsolete comment in G1RootProcessor::process_java_roots
  • fa58aae: 8265245: depChecker_ don't have any functionalities
  • a2b0e0f: 8265323: Leftover local variables in PcDesc

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 19, 2021
@egahlin
Copy link
Member Author

egahlin commented Apr 20, 2021

/integrate

@openjdk openjdk bot closed this Apr 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 20, 2021
@openjdk
Copy link

openjdk bot commented Apr 20, 2021

@egahlin Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit d613459.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants