Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265106: IGV: Enforce en-US locale while parsing ideal graph #3563

Closed

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Apr 19, 2021

IGV is designed to support parsing incomplete XML. However, it does not work for non-English users. See #3071 for detailed reasons. This patch would address it.

(P.S. Locale.ENGLISH also does not work, see Philip Helger' comment on the first answer.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265106: IGV: Enforce en-US locale while parsing ideal graph

Reviewers

Contributors

  • Roberto Castañeda Lozano <rcastanedalo@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3563/head:pull/3563
$ git checkout pull/3563

Update a local copy of the PR:
$ git checkout pull/3563
$ git pull https://git.openjdk.java.net/jdk pull/3563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3563

View PR using the GUI difftool:
$ git pr show -t 3563

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3563.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@kelthuzadx The following labels will be automatically applied to this pull request:

  • build
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 19, 2021

/label remove build

Loading

@openjdk openjdk bot removed the build label Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@kelthuzadx
The build label was successfully removed.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 19, 2021

Thanks @robcasloz for giving this purposed fix!

/contributor add @robcasloz

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@kelthuzadx
Contributor Roberto Castañeda Lozano <rcastanedalo@openjdk.org> successfully added.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2021

Webrevs

Loading

@robcasloz
Copy link
Contributor

@robcasloz robcasloz commented Apr 19, 2021

Hi Yang, I tested this on Linux by opening a file missing closing group and graphDocument tags (incomplete.xml), and it works for the following configurations:

  • JDK versions 8, 11, and 15
  • export LC_ALL=es_ES.UTF-8, export LC_ALL=en_US.UTF-8

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 19, 2021

Thank you Roberto for additional testing :)

It also works for my following configuration:

  • Windows 10
  • JDK 15
  • Both en-US and zh-CN (Systme Locale, not LC_ALL environment variable)

Loading

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks reasonable to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265106: IGV: Enforce en-US locale while parsing ideal graph

Co-authored-by: Roberto Castañeda Lozano <rcastanedalo@openjdk.org>
Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • 739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • 40ef00c: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 3f0da35: 8261392: Exclude testlibrary_tests/ctw/JarDirTest.java
  • 8d0faaf: 8257001: Improve Http Client Support
  • 9bf055d: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • ddc56d1: 8259428: AlgorithmId.getEncodedParams() should return copy
  • ae33d2a: 8258247: Couple of issues in fix for JDK-8249906
  • ... and 44 more: https://git.openjdk.java.net/jdk/compare/66f89870f226f499ce8d89a8b51357484bf7f694...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@openjdk openjdk bot added the ready label Apr 20, 2021
Copy link
Member

@chhagedorn chhagedorn left a comment

Looks good.

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Apr 21, 2021

Thank Tobias and Christian for reviews, and thanks Roberto for your suggested fix~

Now let me
/integrate
it.

Loading

@openjdk openjdk bot added the sponsor label Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@kelthuzadx
Your change (at version f12112e) is now ready to be sponsored by a Committer.

Loading

@TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Apr 21, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@TobiHartmann @kelthuzadx Since your change was applied there have been 55 commits pushed to the master branch:

  • 3de0dcb: 8265483: All-caps “JAVA” in the top navigation bar
  • 739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • 40ef00c: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 3f0da35: 8261392: Exclude testlibrary_tests/ctw/JarDirTest.java
  • 8d0faaf: 8257001: Improve Http Client Support
  • 9bf055d: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • ddc56d1: 8259428: AlgorithmId.getEncodedParams() should return copy
  • ... and 45 more: https://git.openjdk.java.net/jdk/compare/66f89870f226f499ce8d89a8b51357484bf7f694...master

Your commit was automatically rebased without conflicts.

Pushed as commit b5c92ca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kelthuzadx kelthuzadx deleted the enforce_igv_english_locale branch Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants