Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265421: java/lang/String/StringRepeat.java test is missing a memory requirement #3566

Closed
wants to merge 2 commits into from

Conversation

@mychris
Copy link
Member

@mychris mychris commented Apr 19, 2021

Please review the following patch, which fixes the mentioned test case for memory constrained devices. This can be tested on a linux based development machine, using systemd as follows:

$ systemd-run --user --scope -p MemoryMax=800M -p MemorySwapMax=0 /usr/bin/make TEST="test/jdk/java/lang/String/StringRepeat.java" run-test

I split up the test case in a part which only executes the small repeat counts, and in one part which executes the huge repeat count. The second part is guarded by a requirement, so it is only executed if enough memory is available.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265421: java/lang/String/StringRepeat.java test is missing a memory requirement

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3566/head:pull/3566
$ git checkout pull/3566

Update a local copy of the PR:
$ git checkout pull/3566
$ git pull https://git.openjdk.java.net/jdk pull/3566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3566

View PR using the GUI difftool:
$ git pr show -t 3566

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3566.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2021

👋 Welcome back cgo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@mychris The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Apr 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@mychris This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265421: java/lang/String/StringRepeat.java test is missing a memory requirement

Reviewed-by: jlaskey, shade, ryadav

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

  • b5c92ca: 8265106: IGV: Enforce en-US locale while parsing ideal graph
  • 3de0dcb: 8265483: All-caps “JAVA” in the top navigation bar
  • 739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • 40ef00c: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 3f0da35: 8261392: Exclude testlibrary_tests/ctw/JarDirTest.java
  • 8d0faaf: 8257001: Improve Http Client Support
  • 9bf055d: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/e390e550fad353fbb2986b7afc50a2d9407b2ed6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@JimLaskey, @shipilev, @rhyadav) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 19, 2021
@@ -27,21 +27,33 @@
* @run main/othervm -Xmx2g StringRepeat

This comment has been minimized.

@shipilev

shipilev Apr 19, 2021
Contributor

So, does -Xmx2g make sense in this configuration now?

This comment has been minimized.

@mychris

mychris Apr 19, 2021
Author Member

No, not really. The first test case instance should require way less than 1G of memory, so I will just remove the heap configuration for that instance.

@mychris
Copy link
Member Author

@mychris mychris commented Apr 21, 2021

Thanks a lot for the reviews.

/integrate

@openjdk openjdk bot added the sponsor label Apr 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@mychris
Your change (at version 4a2b04a) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Contributor

@shipilev shipilev commented Apr 21, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2021

@shipilev @mychris Since your change was applied there have been 49 commits pushed to the master branch:

  • b5c92ca: 8265106: IGV: Enforce en-US locale while parsing ideal graph
  • 3de0dcb: 8265483: All-caps “JAVA” in the top navigation bar
  • 739769c: 8265411: Avoid unnecessary Method::init_intrinsic_id calls
  • a22ad03: 8264983: Add gtest for JDK-8264008
  • 91b08b7: 8261779: JCK test api/javax_crypto/EncryptedPrivateKeyInfo/Ctor4.html is failing with assertion error when assertions enabled
  • 2fcd920: 8261183: Follow on to Make lists of normal filenames
  • 40ef00c: 8258457: testlibrary_tests/ctw/JarDirTest.java fails with InvalidPathException on windows
  • 3f0da35: 8261392: Exclude testlibrary_tests/ctw/JarDirTest.java
  • 8d0faaf: 8257001: Improve Http Client Support
  • 9bf055d: 8259633: compiler/graalunit/CoreTest.java fails with NPE after JDK-8244543
  • ... and 39 more: https://git.openjdk.java.net/jdk/compare/e390e550fad353fbb2986b7afc50a2d9407b2ed6...master

Your commit was automatically rebased without conflicts.

Pushed as commit 7146104.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants