Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8197811 : Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows #3567

Closed
wants to merge 1 commit into from

Conversation

@trebari
Copy link
Member

@trebari trebari commented Apr 19, 2021

The test PopupPosTest.java fails for windows every time, and was problem listed.
This test was added under the JDK-5044150, And the change was specific to XToolkit as mentioned in JDK-5044150.
"this change is for XToolkit thus testing it on Linux will be sufficient"/

This test runs fine in linux(i have tested on ubuntu).
So making this test linux specific.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3567/head:pull/3567
$ git checkout pull/3567

Update a local copy of the PR:
$ git checkout pull/3567
$ git pull https://git.openjdk.java.net/jdk pull/3567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3567

View PR using the GUI difftool:
$ git pr show -t 3567

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3567.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2021

👋 Welcome back trebari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@trebari The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt label Apr 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@trebari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 7d01c98: 8265414: Variable assigned but not used in G1FreeHumongousRegionClosure

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 19, 2021
@trebari
Copy link
Member Author

@trebari trebari commented Apr 19, 2021

/integrate

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@trebari Since your change was applied there has been 1 commit pushed to the master branch:

  • 7d01c98: 8265414: Variable assigned but not used in G1FreeHumongousRegionClosure

Your commit was automatically rebased without conflicts.

Pushed as commit d1c8c9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@trebari trebari deleted the 8197811 branch Apr 19, 2021
@mrserb
Copy link
Member

@mrserb mrserb commented Apr 20, 2021

Please provide a root cause of the test failure, why the test cannot be run on windows?
The next comment "this change is for XToolkit thus testing it on Linux will be sufficient" was about instruction for the SQE on how to verify the fix.

@mrserb
Copy link
Member

@mrserb mrserb commented May 19, 2021

PIng.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants