-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8197811 : Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows #3567
Conversation
👋 Welcome back trebari! A progress list of the required criteria for merging this PR into |
@trebari This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@trebari Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit d1c8c9e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please provide a root cause of the test failure, why the test cannot be run on windows? |
PIng. |
The test PopupPosTest.java fails for windows every time, and was problem listed.
This test was added under the JDK-5044150, And the change was specific to XToolkit as mentioned in JDK-5044150.
"this change is for XToolkit thus testing it on Linux will be sufficient"/
This test runs fine in linux(i have tested on ubuntu).
So making this test linux specific.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3567/head:pull/3567
$ git checkout pull/3567
Update a local copy of the PR:
$ git checkout pull/3567
$ git pull https://git.openjdk.java.net/jdk pull/3567/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3567
View PR using the GUI difftool:
$ git pr show -t 3567
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3567.diff