8265017: runtime/HiddenClasses/StressHiddenClasses.java timed out on Win* OCI

[hseigel]

Please review this small test change to try to prevent test StressHiddenClasses,java from timing out. The change increases the test's timeout and prints some output the could be useful in future timeouts.

The test was run over 1000 times on Windows with this change without any failures.

Thanks, Harold

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8265017: runtime/HiddenClasses/StressHiddenClasses.java timed out on Win* OCI

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3574/head:pull/3574
$ git checkout pull/3574

Update a local copy of the PR:
$ git checkout pull/3574
$ git pull https://git.openjdk.java.net/jdk pull/3574/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3574

View PR using the GUI difftool:
$ git pr show -t 3574

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3574.diff

[bridgekeeper]

👋 Welcome back hseigel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hseigel The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fbfc4f03)

[dholmes-ora]

Hi Harold,

Your change to add the timeout seems fine and trivial.

But ... I don't understand what this test is trying to do. With PARSE_TIMEOUT set to zero this test doesn't stress anything it just spawns 40000 threads sequentially and has the new thread define a hidden class, which AFAICS the main thread could do directly. ???

Cheers,
David

[openjdk]

@hseigel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265017: runtime/HiddenClasses/StressHiddenClasses.java timed out on Win* OCI

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 787908c: 8264221: Rewrite confusing stream API chain in SnippetMaps
• 142edd3: 8265152: jpackage cleanup fails on Windows with IOException deleting msi
• ab22407: 8265486: ProblemList javax/sound/midi/Sequencer/Recording.java on macosx-aarch64
• e0fd5fc: 8265028: JDWP debug agent thread lookup can be made faster
• 713483c: 8265373: Change to GCC 10.3 for building on Linux at Oracle
• 3990713: 8265463: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp
• 5b43b39: 8263154: [macos] DMG builds have finder errors
• 54cb388: 8252600: [JVMCI] remove mx configuration
• b703e0a: 8264569: Remove obsolete error messages from CDSTestUtils.java
• 235daea: 8265285: Unnecessary inclusion of bytecodeHistogram.hpp
• ... and 1 more: https://git.openjdk.java.net/jdk/compare/5303ccb885fe2bf8b27c3eacafe1facf2f4f9e16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hseigel]

Thanks David for reviewing this! I created a new RFE to look into improving this test: JDK-8265694.

/integrate

[openjdk]

@hseigel Since your change was applied there have been 51 commits pushed to the master branch:

• 0136c89: 8265490: Unterminated string passed to FindClass() in hotspot test
• 325edbc: 8265450: Merge PreservedMarksSet::restore code paths
• b337f63: 8037397: RegEx pattern matching loses character class after intersection (&&) operator
• 07a7510: 8200145: Conditional expression mistakenly treated as standalone
• 41fc7dd: 8199079: Test javax/swing/UIDefaults/6302464/bug6302464.java is unstable
• 45c474a: 8168408: Test java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java fails intermittentently on windows
• 18ee419: 8198422: Test java/awt/font/StyledMetrics/BoldSpace.java is unstable
• da86029: 8265326: Strange Characters in G1GC GC Log
• 7879adb: 8265343: Update Debian-based cross-compilation recipes
• 98cb81b: 8265237: String.join and StringJoiner can be improved further
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/5303ccb885fe2bf8b27c3eacafe1facf2f4f9e16...master

Your commit was automatically rebased without conflicts.

Pushed as commit f45d460.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.