Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265463: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp #3575

Closed
wants to merge 2 commits into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Apr 19, 2021

A couple of trivial fixes to ProblemList a couple of tests in -Xcomp configs:

  • JDK-8265463 ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp
  • JDK-8265464 ProblemList vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 in -Xcomp configs

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8265463: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp
  • JDK-8265464: ProblemList vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 in -Xcomp configs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/3575/head:pull/3575
$ git checkout pull/3575

Update a local copy of the PR:
$ git checkout pull/3575
$ git pull https://git.openjdk.java.net/jdk pull/3575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3575

View PR using the GUI difftool:
$ git pr show -t 3575

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/3575.diff

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 19, 2021

/label add hotspot-runtime
/label add hotspot-compiler

Loading

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 19, 2021

/issue add JDK-8265463
/issue add JDK-8265464

Loading

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dcubed-ojdk
The hotspot-compiler label was successfully added.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dcubed-ojdk This issue is referenced in the PR title - it will now be updated.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dcubed-ojdk
Adding additional issue to issue list: 8265464: ProblemList vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 in -Xcomp configs.

Loading

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Apr 19, 2021
@openjdk openjdk bot added the rfr label Apr 19, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2021

Webrevs

Loading

vidmik
vidmik approved these changes Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8265463: ProblemList vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java on Win-X64 -Xcomp
8265464: ProblemList vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize/Test.java#id1 in -Xcomp configs

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5b43b39: 8263154: [macos] DMG builds have finder errors
  • 54cb388: 8252600: [JVMCI] remove mx configuration

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Apr 19, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Apr 19, 2021

@vidmik - Thanks for the fast review!

/integrate

Loading

@openjdk openjdk bot closed this Apr 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Apr 19, 2021

@dcubed-ojdk Since your change was applied there have been 2 commits pushed to the master branch:

  • 5b43b39: 8263154: [macos] DMG builds have finder errors
  • 54cb388: 8252600: [JVMCI] remove mx configuration

Your commit was automatically rebased without conflicts.

Pushed as commit 3990713.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@dcubed-ojdk dcubed-ojdk deleted the JDK-8265463 branch Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants